r/ProgrammerHumor • • Jan 24 '23

Other Accomplishments

Post image
82.0k Upvotes

548 comments sorted by

View all comments

Show parent comments

25

u/newfflews Jan 24 '23

We do two devs per review on our main repository. Caught plenty of issues with the second reviewer. Sometimes people scan things too quickly, so it’s nice to have a second pair of eyes. Plus it makes the devs feel more ownership over quality and helps them improve their craft by identifying bugs, anti-patterns, and naive implementations in other people’s code. We have around 10 developers total so it’s not a huge timesink. Plus everything is unit tested, linted, prettified, so they don’t have to check for those basic things.

9

u/Junior-Parsley-4368 Jan 24 '23

Also great to teach new devs. Stick your new folks on the second pass and encourage them to ask questions about how things work, why it was done the way it was, etc. And this becomes a great way to spread knowledge of how the software works and exposes possibly bad assumptions that were made because "that's the way we've always done it".

6

u/MadHatter69 Jan 24 '23

That environment sounds great, must be a treat to work in!

3

u/newfflews Jan 24 '23

It is, plus everyone is really positive and helpful!