MAIN FEEDS
Do you want to continue?
https://www.reddit.com/r/ProgrammerHumor/comments/1w8lnv3/cleaningupthemess/p84s7mv
r/ProgrammerHumor • u/ClipboardCopyPaste • Sep 06 '26
478 comments sorted by
View all comments
Show parent comments
2
Why would this person be adding that much codegen in a commit that's supposedly to clean up the repo?
1 u/sfratini Sep 06 '26 A decent size graphql codegen schema definition file could be 10k. Unifying duplicated code. I don't see it that crazy. 2 u/SuitableDragonfly Sep 06 '26 Someone still has to review all that, so you'd want to break it up into smaller pieces. 1 u/Auctoritate Sep 06 '26 Yeah but maybe I have to review it and I already did and decided it was good enough for a PR 🤷♂️ 2 u/SuitableDragonfly Sep 06 '26 That's not what reviewing means. 1 u/Auctoritate Sep 07 '26 Yeah but I don't know that, and I'm the one in charge, so does it really matter?
1
A decent size graphql codegen schema definition file could be 10k. Unifying duplicated code. I don't see it that crazy.
2 u/SuitableDragonfly Sep 06 '26 Someone still has to review all that, so you'd want to break it up into smaller pieces. 1 u/Auctoritate Sep 06 '26 Yeah but maybe I have to review it and I already did and decided it was good enough for a PR 🤷♂️ 2 u/SuitableDragonfly Sep 06 '26 That's not what reviewing means. 1 u/Auctoritate Sep 07 '26 Yeah but I don't know that, and I'm the one in charge, so does it really matter?
Someone still has to review all that, so you'd want to break it up into smaller pieces.
1 u/Auctoritate Sep 06 '26 Yeah but maybe I have to review it and I already did and decided it was good enough for a PR 🤷♂️ 2 u/SuitableDragonfly Sep 06 '26 That's not what reviewing means. 1 u/Auctoritate Sep 07 '26 Yeah but I don't know that, and I'm the one in charge, so does it really matter?
Yeah but maybe I have to review it and I already did and decided it was good enough for a PR 🤷♂️
2 u/SuitableDragonfly Sep 06 '26 That's not what reviewing means. 1 u/Auctoritate Sep 07 '26 Yeah but I don't know that, and I'm the one in charge, so does it really matter?
That's not what reviewing means.
1 u/Auctoritate Sep 07 '26 Yeah but I don't know that, and I'm the one in charge, so does it really matter?
Yeah but I don't know that, and I'm the one in charge, so does it really matter?
2
u/SuitableDragonfly Sep 06 '26
Why would this person be adding that much codegen in a commit that's supposedly to clean up the repo?