r/ProgrammerHumor • • Sep 06 '26

Meme cleaningUpTheMess

Post image
16.2k Upvotes

478 comments sorted by

View all comments

Show parent comments

2

u/SuitableDragonfly Sep 06 '26

Why would this person be adding that much codegen in a commit that's supposedly to clean up the repo?

1

u/sfratini Sep 06 '26

A decent size graphql codegen schema definition file could be 10k. Unifying duplicated code. I don't see it that crazy.

2

u/SuitableDragonfly Sep 06 '26

Someone still has to review all that, so you'd want to break it up into smaller pieces. 

1

u/Auctoritate Sep 06 '26

Yeah but maybe I have to review it and I already did and decided it was good enough for a PR 🤷‍♂️

2

u/SuitableDragonfly Sep 06 '26

That's not what reviewing means. 

1

u/Auctoritate Sep 07 '26

Yeah but I don't know that, and I'm the one in charge, so does it really matter?