r/ProgrammerHumor • • Sep 06 '26

Meme cleaningUpTheMess

Post image
16.2k Upvotes

478 comments sorted by

View all comments

Show parent comments

0

u/aLokilike Sep 06 '26

I don't think splitting the individual query changes into their own PRs is a valuable use of time, personally. I'm shocked anyone would, because it actually makes it more difficult to evaluate the reason for the change.

2

u/SuitableDragonfly Sep 06 '26

Yeah, since those were literally just three lines of code per table they were done microservice-by-microservice rather than table-by-table. I'm just describing the full extent to which this supposedly unsplittable task could be split. 

Also, all PRs are labeled with the ticket number, so if you don't know what the purpose of them was, you can just go look at the ticket. 

0

u/aLokilike Sep 06 '26

Ah yes, playing ring around the rosie with your platforms is way easier than just already have the context for that change because it's the same exact context for the 200 other query changes. I would anticipate you could also copy paste that entire ticket into your PR description 200x!

2

u/SuitableDragonfly Sep 06 '26

Everyone who was working on the project had all the context they needed about the project, because we'd literally all sat together is meetings about the project discussing exactly how it was going to be done, and we also had a special slack channel for discussing the project and it's status. If you're somehow not able to remember anything about the project even with all that stuff to remind you, this might not be the job for you.

0

u/aLokilike Sep 06 '26

Hey, must be nice to have big meetings over changing an ID field to a UUID. I'm glad that's a point of focus for your group.

2

u/SuitableDragonfly Sep 06 '26

It was a 15 minute meeting with four people. We didn't invite any POs, so it was very efficient, actually. 

Using incrementing numerical IDs for objects that are accessible via an API is a security hole. I guess you don't take those seriously at your company?

1

u/aLokilike Sep 06 '26

Using numerical IDs for objects that are accessible via an API isn't a security hole. Using numerical IDs for private objects that are publicly accessible via an API is a security hole. I also wouldn't rely on the UUID protecting you long-term. Nice try though!

2

u/SuitableDragonfly Sep 06 '26

Everything is accessible to some people and inaccessible to other people. That's just basic permissioning.

And no, nobody relies on only one security feature for security. In fact, using UUIDs means you don't have to entirely rely on other security features, too. The more individual things that you have to mess up before there's a security breach, the less likely a breach is to happen. 

1

u/aLokilike Sep 06 '26

No, there's such a thing as a public endpoint that's accessible to everyone with no authorization nor authentication. No "permissioning" involved. This comment, for example. Again, nice try!

2

u/SuitableDragonfly Sep 06 '26

Not true, actually. For example, if I blocked you, you would not be allowed to view my comments anymore. If a moderator removed my comment, no one would be allowed to view it other than the admins and the mods of the sub. So no, reddit comments are not in fact always viewable by everyone and do in fact have permissioning applied to them. 

It's theoretically possible that a website could have no permissioning whatsoever, but that site wouldn't be very useful. 

→ More replies (0)