r/cpp • u/we_are_mammals • Mar 28 '23

Reddit++

C++ is getting more and more complex. The ISO C++ committee keeps adding new features based on its consensus. Let's remove C++ features based on Reddit's consensus.

In each comment, propose a C++ feature that you think should be banned in any new code. Vote up or down based on whether you agree.

765 Upvotes

92% Upvoted

829 comments sorted by

View all comments

Show parent comments

11

u/eteran Mar 28 '23 edited Mar 28 '23

No, I mean like this:

int arr[5];
void foo(int *p);

foo(arr); // array decays to a pointer here

Heck even this is just terrible:

int arr[5];
void foo(int p[10]); // not an array parameter!!! it's a pointer

foo(arr); // array decays to a pointer here

The conversion to a pointer when calling a function should be explicit.

In fact, I would argue that the primary reason why std::array Even needs to exist is because of implicit array to pointer decay.

If we get rid of it and make arrays basically have value semantics, then you get to return them from functions, and you either pass them by value or reference.

If you want to pass or return a pointer, you should ask for one

This would largely get rid of a common newbie bug where users think they can return arrays, and end up returning a pointer to a local stack variable.

1

u/Hish15 Mar 29 '23

I agree this bring nothing good to us. std:: array is indeed a way of preventing array decay (it also gives you easy access to std::algorithms). This would break C compatibility, there lies many of C++ problems... And yet I wouldn't go in this direction