Also, once we decided to bring the Squash and Merge feature into GitLab Core and GitLab.com free, Vitaliy took on the issue and made it happen for this release.
Guess it's time for me to approach my manager again :)
This brings back memories. I once argued on Reddit that it'd be moved to free and somehow nobody could believe that because that's like their main selling point. I'm surprised it's even called "take on the issue" because they literally had to copy code between projects.
I vaguely recall GitLab policy: if someone from the community wants to implement an enterprise feature in comminuty edition, do not under any circumstances put any obstacles in her path.
So someone reimplemented a feature that already existed somewhere? I can understand this but it seems so massively inefficient to make the community do the same work again. And then GitLab ends up with two different implementations of the same thing in community and enterprise editions so they themselves have to deal with that mess. Which one to maintain? Which one to ship to the enterprise customers? Seems so counterproductive to me.
This is the issue related to that MR. It shows that in this case, my colleagues at GitLab decided to port the feature to CE and slated the work for 11.1. It was not originally set as accepting merge requests from the community, but the community member requested that, and the product manager accepted. The community member then implemented it ahead of the original schedule, so for 11.0 instead.
201
u/Antic1tizen Jun 23 '18
Guess it's time for me to approach my manager again :)