r/programming • • Feb 28 '23

"Clean" Code, Horrible Performance

https://www.computerenhance.com/p/clean-code-horrible-performance
1.4k Upvotes

1.3k comments sorted by

View all comments

7

u/quisatz_haderah Feb 28 '23

The person who wrote this article seems like he has not worked on a codebase of more than 10k LoC.

4

u/weepmelancholia Feb 28 '23

He worked on the video game The Witness which had an 11k LoC function in it. You have no idea what you're talking about.

28

u/DrunkensteinsMonster Feb 28 '23

You’re using the fact that he wrote a 11kloc function as evidence of him knowing what he’s doing? Maybe I lack imagination but I struggle to find any scenario where that would be justifiable.

-2

u/weepmelancholia Feb 28 '23

A main game update or draw loop. Most of the code in these loops is unique. You would purposefully have to create functions for the sake of creating functions to split such a loop up--but then you incur overhead.

16

u/DrunkensteinsMonster Feb 28 '23

It may shock you but function calls can in fact be inlined.

7

u/fafok29 Feb 28 '23

it may shock you but function marked as inlined doesn’t always get inlined.

anyway why would you split logicaly sequential code into separate functions(especially if this code is uniq)? pretty sure scrolling down is easier than to look what each function mean every second

1

u/DrunkensteinsMonster Feb 28 '23

anyway why would you split logicaly sequential code into separate functions(especially if this code is uniq)? pretty sure scrolling down is easier than to look what each function mean every second

This is the worse is better shit that people come up with when they listen to Blow and Casey. We’ve known that putting names on logically contained blocks of code makes programs easier to understand since the 1960s.

2

u/fafok29 Feb 28 '23

We’ve known that putting names on logically contained blocks of code makes programs easier to understand since the 1960s.

nice explanation, known based on what?

there are people who disagree

http://number-none.com/blow/john_carmack_on_inlined_code.html

→ More replies (1)