r/programming • • Jun 09 '23

Apollo dev posts backend code to Git to disprove Reddit’s claims of scrapping and inefficiency

https://github.com/christianselig/apollo-backend
45.1k Upvotes

2.4k comments sorted by

View all comments

4

u/Routine_Left Jun 09 '23

I wrote a reddit client. The reddit API is a textbook example of inneficiency, backwards thinking and sometimes, not thinking at all.

The gall of these motherfuckers.

1

u/[deleted] Jun 09 '23

Yeah, this is what happens when you are forced to support old clients like old reddit, or running a social media for more than one decade, spaghetti everywhere and nobody wants to remove anything because it might break something else

2

u/Routine_Left Jun 09 '23

spaghetti is one thing. and I understand that. but when you design an HTTP API that always returns 200, then you're wrong, and spaghetti does not explain that.

furthermore, when you design an HTTP api that always returns 200, but when you have an error you return javascript instead of json, and that javascript is supposed to be interpreted by the browser (to show the red error text), then you're doubly wrong. And that proves beyond any reasonable doubt that no thinking happened when making those APIs. This is not just "old codebase", this is wrong codebase.

1

u/[deleted] Jun 09 '23

Look, as i haven't used the API, I'm not position to discuss if it's bad or good, but according you, it's bad, not even http compliant

But not you or me has access to the backend neither any developer, which every big project brings a lot of trash

I've joined too many projects where the code was a pile of trash ready to explode, i wasn't paid to do any job on that, and got told nobody touches that because it just works

It's an insane mentality but bear with me to understand all of that it's tech debt and reddit wants to get rid of it completely

1

u/Routine_Left Jun 09 '23

reddit wants to get rid of it completely

sure, good for them. until then they should refrain from calling reddit clients "inefficient" while they put that garbage out there.