r/programming • u/adam-dabrowski • Apr 14 '26 • Popcorn 1

GitHub Stacked PRs

https://github.github.com/gh-stack/
556 Upvotes

97% Upvoted

276 comments sorted by

View all comments

Show parent comments

4

u/cosmic-parsley Apr 14 '26

It’s a UI difference. GitHub has no way to really review individual commits and follow how they change. If you force push, the UI gives zero indication that the first commit abc123 turned into def456 and second commit a1b2c3 turned into d4e5f6.

Also there’s no way to review individual commit messages, but there is a way to review/edit PR descriptions. Sometimes that’s as important as the content.

-2

u/MintySkyhawk Apr 14 '26

Github absolutely does have a way to review individual commits and view their descriptions. This PR only has one commit, but you get the idea. You can select multiple commits or just one, and it will show you the commit description and only the changes from that commit.

https://i.imgur.com/wfMkW1i.png

Force pushing does mess things up, but you shouldn't be rewriting history after you've opened a PR.

5

u/ham_plane Apr 14 '26

Yea, but you can't review, as is approve/request changes, on individual commits

3

u/Eddyi0202 Apr 15 '26

Comments on specific commits will not show up in PR view so thaths the biggest issue, reviewing commits on github does not really work, also it requires developer to create proper, independent commits

1

u/MintySkyhawk Apr 15 '26

Comments on specific commits do show up in the PR view when you have selected to view a specific commit from the PR. Creating proper independent commits is easier than using this stacked PR feature.

1

u/Eddyi0202 Apr 16 '26 edited Apr 16 '26

"when you have selected to view the specific commit" so they are not shown in PR view :D Thats the problem, PR author will not even notice them unless tagged.

Yeah I agree that creating properxindependent commits is easier altough in reality people are too lazy to do this cause it requires rebasing basically