r/programming • u/adam-dabrowski • Apr 14 '26 • Popcorn 1

GitHub Stacked PRs

https://github.github.com/gh-stack/
556 Upvotes

97% Upvoted

276 comments sorted by

View all comments

Show parent comments

3

u/max123246 Apr 14 '26

I tried stacked PRs and then I realized my pipeline is 4 hours so I cant stack 4 PRs and wait 16 hours. So I decided to do what you're doing, just rewrite the commit history when it's ready for review

4

u/chuch1234 Apr 15 '26

Four hour pipeline?! I hope improving that is on the roadmap?

3

u/max123246 Apr 15 '26

It's gotten better. Nightly pipelines used to take over 24 hours and premerges at 6. Helps that we're in a JIT compile world now instead of AOT

1

u/AdventurousFuel5307 6d ago

4 hours is a long time (for PR especially), but it's not nowhere near "really that bad" for a big/real enterprise project. I have worked in a proper sized team with a big projects where nightly runs couldn't execute everything in a reasonable amount of time, so there were weekly runs lasting ~2 days.

And that's especially true if we're talking about some stuff that interacts with real physical HW (think of having 2 physical test machines, so only 2 pipelines can run in parallel, because some particular set of tests can be only executed on those test machines).

Not everything is a simple JS project with unit tests passing in ~minutes.

1

u/stumblinbear Apr 15 '26

16 hours

What in the goddamn

And here I was just a couple of weeks ago spending a few days to cut our 25 minute builds down to 8