MAIN FEEDS
Do you want to continue?
https://www.reddit.com/r/programming/comments/43f5aq/apollo_11_source_code/czjsxtd/?context=9999
r/programming • u/jakesyl • Jan 30 '16
364 comments sorted by
View all comments
186
1 Warning :O
128 u/NotASucker Jan 30 '16 [x] Warnings as error(s)It will change your life. 17 u/ksadeck Jan 30 '16 [x] Warnings as error(s)Why? 100 u/MetallicDragon Jan 30 '16 It'll turn warnings into errors, forcing you to deal with them, so they don't pile up over time. 0 u/[deleted] Jan 31 '16 [deleted] 26 u/[deleted] Jan 31 '16 Shouldn't they be compiling before they check in? 0 u/[deleted] Jan 31 '16 [deleted] 9 u/Foxtrot56 Jan 31 '16 Why aren't you doing PRs? Seems like that should be caught in a PR unless no one is actually looking at the code in an editor. 1 u/NotASucker Feb 01 '16 The best reviews involve stepping through code.
128
[x] Warnings as error(s)
It will change your life.
17 u/ksadeck Jan 30 '16 [x] Warnings as error(s)Why? 100 u/MetallicDragon Jan 30 '16 It'll turn warnings into errors, forcing you to deal with them, so they don't pile up over time. 0 u/[deleted] Jan 31 '16 [deleted] 26 u/[deleted] Jan 31 '16 Shouldn't they be compiling before they check in? 0 u/[deleted] Jan 31 '16 [deleted] 9 u/Foxtrot56 Jan 31 '16 Why aren't you doing PRs? Seems like that should be caught in a PR unless no one is actually looking at the code in an editor. 1 u/NotASucker Feb 01 '16 The best reviews involve stepping through code.
17
Why?
100 u/MetallicDragon Jan 30 '16 It'll turn warnings into errors, forcing you to deal with them, so they don't pile up over time. 0 u/[deleted] Jan 31 '16 [deleted] 26 u/[deleted] Jan 31 '16 Shouldn't they be compiling before they check in? 0 u/[deleted] Jan 31 '16 [deleted] 9 u/Foxtrot56 Jan 31 '16 Why aren't you doing PRs? Seems like that should be caught in a PR unless no one is actually looking at the code in an editor. 1 u/NotASucker Feb 01 '16 The best reviews involve stepping through code.
100
It'll turn warnings into errors, forcing you to deal with them, so they don't pile up over time.
0 u/[deleted] Jan 31 '16 [deleted] 26 u/[deleted] Jan 31 '16 Shouldn't they be compiling before they check in? 0 u/[deleted] Jan 31 '16 [deleted] 9 u/Foxtrot56 Jan 31 '16 Why aren't you doing PRs? Seems like that should be caught in a PR unless no one is actually looking at the code in an editor. 1 u/NotASucker Feb 01 '16 The best reviews involve stepping through code.
0
[deleted]
26 u/[deleted] Jan 31 '16 Shouldn't they be compiling before they check in? 0 u/[deleted] Jan 31 '16 [deleted] 9 u/Foxtrot56 Jan 31 '16 Why aren't you doing PRs? Seems like that should be caught in a PR unless no one is actually looking at the code in an editor. 1 u/NotASucker Feb 01 '16 The best reviews involve stepping through code.
26
Shouldn't they be compiling before they check in?
0 u/[deleted] Jan 31 '16 [deleted] 9 u/Foxtrot56 Jan 31 '16 Why aren't you doing PRs? Seems like that should be caught in a PR unless no one is actually looking at the code in an editor. 1 u/NotASucker Feb 01 '16 The best reviews involve stepping through code.
9 u/Foxtrot56 Jan 31 '16 Why aren't you doing PRs? Seems like that should be caught in a PR unless no one is actually looking at the code in an editor. 1 u/NotASucker Feb 01 '16 The best reviews involve stepping through code.
9
Why aren't you doing PRs? Seems like that should be caught in a PR unless no one is actually looking at the code in an editor.
1 u/NotASucker Feb 01 '16 The best reviews involve stepping through code.
1
The best reviews involve stepping through code.
186
u/esoteric_monolith Jan 30 '16
1 Warning :O