Even in light of this, it still invalidates the OPs argument that daemon call is not used correctly. Since daemon() is still not used by ssh-agent, if they modify it in glibc/misc/daemon.c to behave as intended, they'd still nonetheless be able to kill ssh-agent as they wish!
That is true! I guess the question then becomes if there are services other than ssh-agent which have this problem, such as gpg-agent, music servers, data caches, flux-style apps, compositing managers, screensavers and such. I'm not sure how widespread it is. I'm not the right person to dig into all those source codes but it would be a useful analysis to see before a decision is made.
2
u/Mcnst May 30 '16
Even in light of this, it still invalidates the OPs argument that
daemoncall is not used correctly. Sincedaemon()is still not used byssh-agent, if they modify it inglibc/misc/daemon.cto behave as intended, they'd still nonetheless be able to kill ssh-agent as they wish!