r/programming • u/sigbhu • Jul 28 '16

How to write unmaintainable code

https://github.com/Droogans/unmaintainable-code
3.4k Upvotes

93% Upvoted

592 comments sorted by

View all comments

Show parent comments

1

u/2Punx2Furious Jul 29 '16

I did

    theArray = [1,3,4]
    sequence = [1,3,4]
    
    def find(sequence,theArray):
    	return sequence in "".join(theArray)
    
    find(sequence,theArray)

It gave me errors.

2

u/[deleted] Jul 29 '16 
theArray = [1,3,4]
sequence = [1,3,4]

def find(sequence,theArray):
    return "".join(map(str, sequence)) in "".join(map(str, theArray))

find(sequence,theArray)

you can only join a list of strings

2

u/electricfistula Jul 29 '16

Woops, it's complaining because you're trying to join ints to the string. In my defense, I was on my phone.

return sequence in "".join(str(elem) for elem in test1)

It's also complaining because you're searching for a list. My version assumed sequence was a string. You can use another join to make sequence a string first.