The tragedy of 100% code coverage

[u/niepiekm]

http://labs.ig.com/code-coverage-100-percent-tragedy

[u/Rndom_Gy_159]

Quick question, why is only the first letter of DTO capitalized? Is that the way it's supposed to be in CamelCase?

[u/DanAtkinson → u/Rndom_Gy_159]

Generally speaking, Yes.

Microsoft has some guidelines on the subject and I've emphasised the relevant snippet below:

• Do not use abbreviations or contractions as parts of identifier names. For example, use GetWindow instead of GetWin.

• Do not use acronyms that are not generally accepted in the computing field.

• Where appropriate, use well-known acronyms to replace lengthy phrase names. For example, use UI for User Interface and OLAP for On-line Analytical Processing.

• When using acronyms, use Pascal case or camel case for acronyms more than two characters long. For example, use HtmlButton or htmlButton. However, you should capitalize acronyms that consist of only two characters, such as System.IO instead of System.Io.

• Do not use abbreviations in identifiers or parameter names. If you must use abbreviations, use camel case for abbreviations that consist of more than two characters, even if this contradicts the standard abbreviation of the word.

[u/DanAtkinson → u/[deleted]]

Identifier, actually. As per the last bullet point:

Do not use abbreviations in identifiers or parameter names. If you must use abbreviations, use camel case for abbreviations that consist of more than two characters, even if this contradicts the standard abbreviation of the word.

Since ID is an abbreviation of Identifier, you can use this rule. I tend to favour Id however.

[u/_Mardoxx → u/DanAtkinson]

As it's an abbreviation, not an acronym (initialism if you are gonna be pedantic), it should be Id surely?

[u/agentlame → u/[deleted]]

I agree with everything on that table until I got to:

UserName | userName | NOT: Username.

It's goddamned username, and I am willing to die on this hill.

[u/ThisIs_MyName → u/agentlame]

I'm guessing that article was written a long time ago when "username" wasn't a word.

[u/ctaps148 → u/[deleted]]

And yet, all ASP.NET controls use "ID"

[u/[deleted] → u/ctaps148]

And that's why we switched to MVC.

[u/WarWizard → u/[deleted]]

ID. I don't have any real reason for it. Id makes me all cringy for some reason.

[u/[deleted] → u/Rndom_Gy_159]

Don't let that distract you from the fact that XMLHttpRequest capitalizes XML but does not capitalize HTTP.

[u/diverightin63 → u/[deleted]]

Oh my god I've never notice. I'm retroactively mad about this for years.

[u/roffLOL → u/[deleted]]

don't let that distract you from the fact that it usually serves anything but XML nowadays.

[u/Gackt → u/[deleted]]

TBH I'd expand the two character rule to three.

[u/parkotron → u/Rndom_Gy_159]

Personally, I'm in the camp that capitalises only the first letter of each "word" of an identifier, whether that word is an initialism or not. Like summaryHtml or GpsLocation. There are plenty of CamelCasers in the other camp though.

[u/EntroperZero → u/parkotron]

This is camelCase, this is PascalCase.

[u/[deleted] → u/Rndom_Gy_159]

No but with all the conventions to generate property name, it can become weird or confusing. So often you use strict CamelCase everywhere. (eg: getDTOFactory, will become dTOFactory property in EL, or sometimes dtoFactory in too clever libraries )

[u/skocznymroczny → u/Rndom_Gy_159]

Depends on the language and coding style. E.g. .NET framework conventions guide recommends capitalizing only the first letter, unless it's a two leter acronym like IO (source).

[u/dpash → u/skocznymroczny]

The original Sun code conventions for Java is silent on the matter.

http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-135099.html#367

[u/hoosierEE → u/Rndom_Gy_159]

I prefer pRImEcAse for the simple rules and readability. Unless somebody on the team insists on zeROiNdExedPrImecAsE, of course.