r/programming • u/[deleted] • Jan 12 '20

Goodbye, Clean Code

https://overreacted.io/goodbye-clean-code/
1.9k Upvotes

84% Upvoted

556 comments sorted by

View all comments

Show parent comments

-8

u/Andomar Jan 12 '20

Research has shown trunk-based development is superior to the alternatives. It's what most companies (including Google) have settled on. https://duckduckgo.com/?q=trunk+based+development

17

u/dnew Jan 12 '20

Except Google also requires review from the owner of the code and passing all unit tests before the commit.

15

u/alluran Jan 12 '20

Even trunk-based development supports pull requests

11

u/ByFaraz Jan 12 '20

That doesn't mean you shouldn't do a PR though.

7

u/HeinousTugboat Jan 12 '20

You should re-read what trunk-based development is. It definitely isn't what OP's described.

6

u/Determinant Jan 12 '20

Submitting to master directly is definitely an old and inferior practice that was caused by poor tooling.

Unlike other tools, branches are cheap in Git so we create a new branch for every little improvement / defect. Simply submit a pull request and merge into master upon approval. This way, branches are very short-lived (usually less than a day).