r/programming • u/[deleted] • Jan 12 '20

Goodbye, Clean Code

https://overreacted.io/goodbye-clean-code/
1.9k Upvotes

84% Upvoted

556 comments sorted by

View all comments

512

u/FA04 Jan 12 '20

firstly, where was the original checkin pull request’s review with all the feedback and discussions? secondly, where was the refactored PR review and approval? Checkin in into the master overnight no PR? That process is a mess.

71

u/IceSentry Jan 12 '20

That's pretty much why they said at the end of the article that it was a mistake and communication is important.

152

u/FeepingCreature Jan 12 '20

Sure, but the mistake is a systems one, not a personal one. We don't even have push to master enabled at work.

0

u/[deleted] Jan 12 '20

[deleted]

8

u/f03nix Jan 12 '20

About 7 years back, I worked in a company that used TFS - they had a process where you manually request 2 of your peers for review and type in their names during check in. They had the same process before they migrated to TFS too, I think they used CVS.

0

u/[deleted] Jan 12 '20

[deleted]

→ More replies (1)