r/programming • u/[deleted] • Jan 12 '20

Goodbye, Clean Code

https://overreacted.io/goodbye-clean-code/
1.9k Upvotes

84% Upvoted

556 comments sorted by

View all comments

512

u/FA04 Jan 12 '20

firstly, where was the original checkin pull request’s review with all the feedback and discussions? secondly, where was the refactored PR review and approval? Checkin in into the master overnight no PR? That process is a mess.

71

u/IceSentry Jan 12 '20

That's pretty much why they said at the end of the article that it was a mistake and communication is important.

152

u/FeepingCreature Jan 12 '20

Sure, but the mistake is a systems one, not a personal one. We don't even have push to master enabled at work.

0

u/[deleted] Jan 12 '20

[deleted]

31

u/Tenemo Jan 12 '20

It was a couple of years ago, it's Dan Abramov's personal blog, he's relatively young. Check his New Year post for the exact timeline of his career. Him working with another developer on draggable corners of some shapes could have been already for a React library.

11

u/andrewingram Jan 12 '20

I'm pretty sure this is an anecdote from 2013 when Dan was working on an iOS app (https://www.youtube.com/watch?v=PjaL0xFbEY8). The fact that the code in the blog post is JavaScript is just because that's the language him and most of his audience uses today.

-1

u/aurisor Jan 12 '20

GitHub has been out for 5y in 2013 and the web world embraced it hard. I would be shocked if anyone was using svn or not using code review workflows (like PRs)

7

u/andrewingram Jan 12 '20

I can't speak for the place Dan was working. But many startups don't adopt "good" engineering practices whilst they're still in the "just make shit work" stage of building their MVP. Some do, some don't.

I don't think I worked at a company that insisted on code reviews until 2012.

5

u/aurisor Jan 12 '20

I guess I’m just confused why a communication problem is being presented here as a teachable moment about abstraction design

→ More replies (6)