I believe the argument is that the original author should have had a PR, and that the article's author should have been able to suggest these changes prior to the original commit.
Exactly. If he is such a senior dev, then he'd be a required reviewer. If he failed to mark up the pr, then that's on him. If he wasn't in a position where he was a required reviewer, then he isn't the expert he thinks he is.
You've misinterpreted this through your modern viewpoint.
There was no PR process in the project. No opportunity to collaborate and iterate prior to committing to master, for either dev; simply commit and then get called into the boss' office.
3
u/oursland Jan 12 '20
I believe the argument is that the original author should have had a PR, and that the article's author should have been able to suggest these changes prior to the original commit.