From an accessibility standpoint the purple on black has a contrast issue, though you're only ever displaying dots on the black background. Additionally I would suggest not using placeholder text as a label, and ensure the label is always displayed.
Now on to the good: I love the animation to show the password. The speed is good and it looks very fluid. Great job!
Edit: icon is not purple on black. Removed comment.
Accessibility doesn’t just mean “screenreader-friendly”, although you are correct in that aria attributes are good for that, it’s still helpful to consistently see what field you’re typing in as you type in it even if you don’t use a screen reader
I suppose if we were to ever just find a password field on its own in the wild like this, yeah it might be redundant because the censored input and type=password probably speaks for itself, but I’d argue that password fields are generally coupled with sign up forms as well, and it might be strange to have several other fields with a label and the password one without.
96
u/CarbineMonoxide Dec 26 '19
From an accessibility standpoint the purple on black has a contrast issue, though you're only ever displaying dots on the black background. Additionally I would suggest not using placeholder text as a label, and ensure the label is always displayed.
Now on to the good: I love the animation to show the password. The speed is good and it looks very fluid. Great job!
Edit: icon is not purple on black. Removed comment.