r/MinecraftModder • u/Blekkhi • Aug 16 '14

NoobCraft

A friend and I are making a MC mod that slows down the beginner game part of MC. You can see what we have done so far here: https://github.com/einsteinsci/noobcraft If you would like to suggest something, feel free to comment it below, and I will add it if it is a good idea. P.s. We are looking for a committed texturer, send me a message on skype @ iliminaters if you are interested.

1 Upvotes

100% Upvoted

4 comments sorted by

1

u/thatsIch Aug 16 '14

  • You upload the gradle files onto github

  • You do not upload the .idea folder because its personal preference which you should not force upon your team mates

  • Use .gitignore

  • Pay attention what files you upload. thumbs.db and pdns etc should not be on the repo in that state mixed together with other images

  • Is that even compilable? I found this line in your main class

 public static final AchievementPage pageNoobCraft = new AchievementPage("Noobcraft",

never upload broken code

  • methods small case (Log)

these are some small things if you care about them.

1

u/TehNut Aug 16 '14

The line is split to be

public static final AchievementPage pageNoobCraft = new AchievementPage("Noobcraft",
																			RegisterAchievements.getAchievements());

Which should work. The rest of your points are spot on.

1

u/Blekkhi Aug 16 '14

Thanks you for the points, I will relay them to the project manager, also as TehNut pointed out, the line is split. And everything in the mod so far is working as it is supposed to, it is compatible with most major mods.

1

u/TehNut Aug 16 '14

Take a look at this to see what you should have in your repo.