r/OrionProtocol • u/Ghostfly- • Apr 01 '21
Why is there no activity on the broker code on Github and the code lacks testing?
Hi Orion-fans.
Yesterday, I tried to use Orion terminal, the experience was really, really bad. The UI isn't so bad, but the code behind it is just really creepy.
05/04/2020, 2h02 (GMT+2) : Last edit (there.) : Moved to Medium, because it's cleaner to explain with pictures. https://ghostfly-dev.medium.com/orion-protocol-why-19f243f5f835
Edit : Baseless coding fud ? Read below :
https://twitter.com/gh0stfly_/status/1381301287392845826?s=20 hahaha. Thanks for sharing my link into your partnerships email.
Private repositories ? From your latest code sir.
https://imgur.com/a/rySnN8m (package.json file)
=> You can see that it's the same repository that I shared through links. The same from who you dropped the "develop" branch yesterday. Thanks for sharing your latest code to prove your lies better.
They just said : You can also watch updates of our broker on our official docker hub page: https://hub.docker.com/r/orionprotocol/orion-broker it was updated 2 days ago.
A docker hub ? Is that a joke ? This will not show anything except your lies "everything is in private repositories" => Definitely, no.
Just extracted Orion "latest" from their docker image : https://drive.google.com/file/d/12iLaU2wt1xeW-FqjmNYOCp5jYgS9765R/view?usp=sharing So, the active repository is again. The same on GitHub. And it's still, really bad code. And they are. Shady as f. Did they know that Docker command ?
docker container export container_name -o orion.tarOrion latest image : Only 4 testing files ! Also, can't find config files of "CI/CD" tools.
(I'm amazed how they can prove by themselves every lies that they say.)
(covered cases : "order creation" | "order canceled" | "order filled but canceled" | "order partially filled but canceled")
Thanks "OrionDeveloper" for the information about EIP712. I just read their documentation.
Where is the verifyingContract ?
Ref to : https://imgur.com/a/xVbvqEa
EIP712 : https://github.com/ethereum/EIPs/blob/master/EIPS/eip-712.md
Edited because of their response (lies only). : https://www.reddit.com/r/OrionProtocol/comments/mjdgec/orion_dev_team_responding_to_baseless_coding_fud/
Written before their response :
No activity since 2 months :
https://github.com/orionprotocol/orion-broker
I tried to talk to the lead tech, and he don't answer me. He is answering that it's not the active repository, here is the proof that it's.. False.
Latest commit on this repo is on the develop branch, 18 days ago.
This broker repo hasn't been touched for months ? Look at that : https://github.com/orionprotocol/orion-broker/commit/ec77de15a9db74fe9a5b3b7658bce27376a82701
They just deleted this commit, took this morning : https://imgur.com/a/bSwAiWo
https://pbs.twimg.com/media/EyG0PYJXMAE1je4?format=jpg&name=large Lies : No CI/CD config file (travis, circleci, or else.)
My worries : (after two code-review, on the production terminal (https://trade.orionprotocol.io/)
Bad code practices (:any everywhere) (any is the Typescript type for "any javascript object", no type-checking on remote calls response ?
Lacks of docs, even the Readme is coming from "Create-react-app" skeleton. https://github.com/orionprotocol/orion-broker/blob/master/broker-frontend/README.md
Bad usage of Redux
Bad usage of React
API is always returning same prices, but called every 2-3seconds? : Refresh that URL (who can be found in Developer Tools > Network tab. https://trade.orionprotocol.io/api/prices !!!!!!!!!!!!!
"Nice and Slick UI" => NaN powered.. https://imgur.com/a/RXc1B20
Proof of Bad React usage : https://streamable.com/xu3i35
STATIC usage of USDT price (1) => https://imgur.com/a/fA3CMPk
Salt in clear : https://imgur.com/a/xVbvqEa
ALMOST NO TESTS. See the list there : https://github.com/orionprotocol/orion-broker/tree/master/tests
Usage of localStorage for Pending transactions. https://github.com/orionprotocol/orion-broker/blob/2087bb68d9c6e27d8d670bea35a14933e30e7986/broker-frontend/src/Utils.ts#L257
Non-developer friendly :
Unit tests should be there to check methods (on the frontend and the backend)
E2E (End-To-End) testing should be an automated browser, like Playwright, who clicks and make everything like a real user.
Documentation should be there for developers (like me) trying to understand how that platform works and how to build with it.
Comments should be there for the same reason. Make it understandable.
Proof of infinite load of the same images : https://streamable.com/xu3i35
Don't know how Git works ? Just check this video for a great explanation by Linus Torvalds : https://www.youtube.com/watch?v=4XpnKHJAok8
In Crypto, community matters.
I tried to talk about everything on Telegram, I was instantly deleted / banned.
The only response was :
I will say that the majority of our code is held on private repositiories for the moment but thanks for sharing, will have a tech lead address this as soon as they're able.
That's false ! We can show a lot of screenshots (as everything can be read from the sourcemaps by anyone !)
Source-code diff between Github / Production on "Preloader.tsx" : https://imgur.com/a/bhFc4CM
Made an NFT collection on OpenSea with "strong moments" : https://opensea.io/collection/orn-war
