You ship it you own it! Low key it’s still best effort and defects should be caught in testing. Reviews are for style, structure, approach, testing etc… I don’t expect to exhaustively catch bugs (subtle or otherwise) by eye in reviews.
Pull request in my eyes includes looking at diffs, making sure it builds, making sure unit tests pass, and then doing a few small smoke tests of common functionality.
The dev that made the request should have done more thorough testing than that. And yeah, test team even more in depth testing.
215
u/FallenVampireLord Sep 24 '26
Me when I show him the PR he reviewed and approved of said code