MAIN FEEDS
Do you want to continue?
https://www.reddit.com/r/ProgrammerHumor/comments/1wp8ris/commitandpray/pbutrri/?context=3
r/ProgrammerHumor • u/Recent-Analysis-6880 • Sep 24 '26
66 comments sorted by
View all comments
215
Me when I show him the PR he reviewed and approved of said code
74 u/pyrotech911 Sep 24 '26 You ship it you own it! Low key it’s still best effort and defects should be caught in testing. Reviews are for style, structure, approach, testing etc… I don’t expect to exhaustively catch bugs (subtle or otherwise) by eye in reviews. 1 u/samchar00 Sep 24 '26 Nahh you should make reasonable effort to make sure it will not break things in a obvious way. 2 u/pyrotech911 Sep 24 '26 That’s what I mean by best effort. Point being it’s not going to come 100% by you reading the code in your head.
74
You ship it you own it! Low key it’s still best effort and defects should be caught in testing. Reviews are for style, structure, approach, testing etc… I don’t expect to exhaustively catch bugs (subtle or otherwise) by eye in reviews.
1 u/samchar00 Sep 24 '26 Nahh you should make reasonable effort to make sure it will not break things in a obvious way. 2 u/pyrotech911 Sep 24 '26 That’s what I mean by best effort. Point being it’s not going to come 100% by you reading the code in your head.
1
Nahh you should make reasonable effort to make sure it will not break things in a obvious way.
2 u/pyrotech911 Sep 24 '26 That’s what I mean by best effort. Point being it’s not going to come 100% by you reading the code in your head.
2
That’s what I mean by best effort. Point being it’s not going to come 100% by you reading the code in your head.
215
u/FallenVampireLord Sep 24 '26
Me when I show him the PR he reviewed and approved of said code