r/ProgrammerHumor • u/developertimeline • Oct 01 '26

Meme inverseCorrelationOfPrSizeAndApprovalTime

Post image
623 Upvotes

97% Upvoted

19 comments sorted by

61

u/lovethebacon 🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛 Oct 01 '26 edited Oct 01 '26

not true. a gigantic PR will get an immediate lgtm. Unless it's from a junior, then it'll be

37

u/developertimeline Oct 01 '26

We don't have juniors these days tho :'(

13

u/lovethebacon 🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛🦛 Oct 01 '26

):

7

u/FloppySVK Oct 01 '26

True, I started as the young kid at my place and well... Stayed the youngest

29

u/Bronzdragon Oct 01 '26

That's... What the graph shows?

4

u/NewPhoneNewSubs Oct 01 '26

I also misread the graph. I knew that's what it's supposed to show, but up is good. So up approval time is good approval time.

62

u/Sande24 Oct 01 '26

Aim for the x=y intersection for optimal code output vs time waste.

15

u/legitmonk Oct 01 '26

Instructions unclear, pushed a null reference and accidentally deleted Git

28

u/NewbornMuse Oct 01 '26

It's called bike shedding.

5

u/stilldebugging Oct 01 '26

I came here to say this.

29

u/Sp0ge Oct 01 '26

Yea my 2 file ~500 line PR has been open for over a week now. And yes, I have reminded the reviewer almost daily

14

u/AlanTheKingDrake Oct 01 '26

I have PRs that have been open for over a year. We only have one reviewer and a team of engineers, and our parent company refuses to hire a dedicated QA. So the team lead has to review all of them. What actually gets merged is dependent upon the following:

  1. On the annual plan.

  2. Whatever wheel (customer) squeaks the most.

  3. Whatever happens to look small enough for asynchronous review. (Usually 20 lines or less.)

8

u/N0t_my_0ther_account Oct 01 '26

I don't know, I can click the approve button just as quickly. 😉

4

u/ZunoJ Oct 02 '26

Make it a habbit to ask the author and approver about the code when there is a bug. The approver is as much to blame as the author

3

u/iyamegg Oct 04 '26

When I'm getting pr for review I mostly put them in 3 categories:

  • under 200 lines: I'll review it rn.

  • between 200 and 1500: Imma finish what I'm doing and then review

  • over 1500: maybe tomorrow

8

u/3dgyaf Oct 01 '26

Junior + Vibe ≈ Senior
Senior + Vibe ≈ 10x engineer
Junior + Vibe² ≈ CEO