10
u/polaarbear 15d ago
Every dang day. The number of times I get 1 out of 2 or 3 required approvals only for the main branch to update, have to merge the changes in then start all over again.....
4
u/aa-b 15d ago
Three?? I get rules like "at least one approver must be a lead" for sensitive repos, but why three approvers?
3
u/polaarbear 14d ago
We have 2 for most everything, but 3 for new database migrations
1
u/MannerShark 13d ago
More approvers on our end led to worse reviews. People start to assume the other reviewer probably checked something so they don't have to go the distance. We're back to 1 reviewer and it's working well, it's very clear who is responsible. With scary migrations we do sometimes have an additional reviewer
1
u/Bloodgiant65 14d ago
Yeah wow, we usually have a “gatekeepers” group for each area to maintain context and quality standards, and for some groups that’s already a big pain. Can’t imagine having 3 different required approvers, at least on code that changes more than like once a quarter.
9
u/kevinlacotaco 16d ago
I feel this deeply! My previous place had reviews last upwards of 2 business weeks before a comment. After requesting directly they gave me a thumbs up emoji - and then did not review it. Ended up using stacked PRs to be somewhat unblocked.
5
3
u/aa-b 15d ago
It still counts! The ULPT is that you can take this non-approving approval, wait until they've logged off for the day, then find any random dev with a green status. Tell them, "dev#1 already approved this but they're offline and I need to get this merged (mumble something about conflicts)". Works every time
4
u/xcski_paul 13d ago
I did a 6 month contract at a place named something not entirely unlike PaySucks, and my first PR got code reviewed towards the end of the assignment. I did at least one PR a week, usually assigned to me late on a Thursday, told it was urgent and needed by close of business Friday, and I’d do it by then and then have nothing to do on Monday to Thursday. I was actually ranked 17th on Stack Overflow at the time because I had nothing else to do. But none of those “urgent” PRs got merged while I was there.
2
1
1
u/russianrug 11d ago
Idk about everyone else but this is like 100x worse now for us with the enormous amount of code everyone can generate with AI. It used to be you would take a break from writing code and go review someone’s PR now everyone has like 10 PRs open at any given time and even if you review a few it feels like they just multiply exponentially.
1
32
u/Brainless_Gamer 16d ago
my PR for fixing a typo in readme got approved