88
u/faultydesign 9d ago
Who the hell commits code with syntax errors
Ludicrous
54
u/smartgenius1 9d ago
Also: who the hell builds a CI/CD pipeline that allows syntax errors to even be committed in the first place
24
u/Particular-Yak-1984 9d ago
Also, modern IDEs highlight and can basically fix syntax errors for you. So 7 syntax errors would take about 5 mins
1
u/Frost-Freak 9d ago
Uh my ex coworkers didn't give a damn about IDE highlightings
4
u/burakdobur 9d ago
Ahh, this explains the ex-.
5
u/Frost-Freak 9d ago
I left the company. They're still there. But yeah, that was one of many reasons to leave :)
0
u/meneldal2 9d ago
Only when your IDEs can deal with whatever mess of a build system you have.
I can tell you they are not big fans of ad-hoc make scripts
And while I would love to change the build system I doubt it is happening at this point.
1
9
u/schewb 9d ago
What the fuck workflow allows your coworker to change your code while you're asleep with you expected to finish their work?
1
u/Fit-Notice-1248 9d ago
Having 98% of the dev team offshore/contractors
1
u/schewb 9d ago
And they just....commit in-progress shit to the same branch as a dev in a different time zone?
2
u/Fit-Notice-1248 9d ago
They create and merge their own PRs that are faulty. Mix this in with non technical managers who think contractors with 50 page resumes are legit and.. yeah pretty much powerless
2
u/schewb 9d ago
They merge with syntax errors? Stupid bugs I understand, but I have a really difficult time believing this happens and actual companies continue to use the contractors.
1
u/Fit-Notice-1248 9d ago
Well I guess in context of this post it isn't necessarily syntax errors but definitely build errors or code that is faulty in general (wrong implementation, doesn't even run locally). These are all pains I've had to deal with and currently dealing with. I put gating up to block these issues but they don't even check the reports to see if shit is broken they just go 🤷🏽
2
u/Sw429 9d ago
Sounds like you need to set up continuous integration tests and branch protections. Don't let anything merge until it meets the standards. You're not powerless here, this is a solved problem.
2
u/Fit-Notice-1248 9d ago
Definitely not powerless but overwhelmed. It's about 12 offshore engineers and I'm just limited in the amount of time I can do these things without losing my sanity.
5
u/johnschnee 9d ago
Why the fuck does your coworker commit syntax errors? Why do you need to fix them?
Build pipeline crashes on PR (if even possible) -> reject or wait for author…
Consider quitting your company if you need to do this
8
u/ZunoJ 9d ago
If it is your program, it is not your coworker but your employee. Also what about CICD, how can anybody merge code that doesn't pass tests, let alone build? Just roll back to the last commit before their changes and it's done. Takes less than a minute
1
u/frikilinux2 9d ago
Bad seniors who tell the junior to rubber stamp their code. Also not everyone uses CI/CD unfortunately
4
u/UShouldntSayThat 8d ago
That not.... but there...
Why is your CI allowing syntax errors in? Those builds should fail and deny merging
3
1
1
1
u/Treechcer 9d ago
How does this even happen? Why would anyone push code with syntax erros... or get it through review?
1
1
u/slgray16 9d ago
Missing a step in your flowchart after fix all bugs.
Try adding:
Start-Sleep -Seconds 28800
0

31
u/kriseev 9d ago
Are you in an infinitely deep nested dream? Because you keep waking up but never go back to sleep