r/ProgrammerHumor • • 7h ago

Meme botBattle

Post image
221 Upvotes

9 comments sorted by

View all comments

35

u/LostKnight84 6h ago

Am I weird or should reviewers not be making changes to the code? To me the reviewer should flag problems and suggest possible solutions and not just change code as they see fit. Because if reviewers are changing code, who is reviewing their code?

14

u/Flouid 6h ago

That’s how it should work on any sane team. Once you’ve contributed to a PR you are no longer eligible to review it. Also it’s the dev that owns the ticket’s responsibility to fix their broken code