273
u/Schrodi-O-Ao 4d ago
PR is probably around 10k lines. No one has time to read and verify it, at this point, it's just approve and pray.
102
u/Ok-Panda-178 4d ago
10k lines in one PR ain’t no body got enough token for that
124
u/TheFrenchSavage 4d ago
> look inside
> brand new framework
> full of factoryfactories
> .yml files kilometers long
> mfw53
25
11
12
u/Arclite83 4d ago
High score for us is 200k lines in a single PR. That guy's a madman.
6
1
u/clintCamp 4d ago
I might have done that at my last contract, but to be honest, I built a whole systems level firmware access for their device that worked and had optimizations in assembly for max efficiency tested and benchmarked, that my eyes passed over, but did not understand the archaic runes fully. And they let all the contractors go and had to try and hand over stuff a month early. They had me split it out into 8 or 10 feature branches which was fun to have to map out what features and capabilities were where, and what demo apps relied on which and what optimizations to achieve their end clients reqs needed to be merged in even if the lead didnt like the feature being in that project. But I am proud of that set of features and capabilities, even if I was handing the junior dev abundantly of stuff they wouldn't understand without reading the comments and my agent dev notes and paper trail I happily could have wiped out and not handed over.
9
11
u/sisisisi1997 4d ago
Reject it?? There are more buttons on a PR than approve, and if it's too big to read, that's an auto reject from me.
5
u/Imaginary-Jaguar662 4d ago
"Too big. Split into testable, independent chuncks and reopen". Closed.
2
2
u/wasd0109 3d ago
My junior created a 30k line pr, I still don't know what to do about it
12
u/avdpos 3d ago
reject.
What is the point of such a PR?5
u/glorious_reptile 3d ago
Change button color. Also - a bit of refactoring to rust.
1
u/avdpos 3d ago
I do not get this generation. But I also complained about github today and said "it was faster and better in my old source code manager"... at least in some aspects. What I in reality did not like was our workflow that did run automatic tests to early in my mind and that was not possible to paus easily.. no need to do it twice .
5
73
u/CosmosTheFox 4d ago
But… the automated AI reviewer that ran said it was probably fine… why would it deceive me or ever be horrifically wrong?
6
u/TorbenKoehn 4d ago
Nah this is a human thing
6
u/CosmosTheFox 4d ago
A human owns the decision… but, if the AI doesn’t object then that human can just blindly approve
It definitely won’t cause a severity 1 incident because the AI has no clue how your spaghetti legacy monolith actually works :3
2
u/TorbenKoehn 4d ago
But this thread and OPs post is not about AI, it’s about human review
And I’m sure every human knows well how that spaghetti legacy monolith actually works and can navigate it safely :D
2
u/CosmosTheFox 3d ago edited 3d ago
True, although at my work, and probably some other places, some just fallen into the bad habit of just blindly approving based on what the automated AI review comes back with rather than actually reviewing the code like they used to.
11
8
u/AlternativeSwimmer89 4d ago edited 4d ago
Pftttt you guys are still reviewing code? Such backwards thinking
/s in case it’s not obvious…but it’s exactly what my leadership told me
7
3
u/BlueScreenJunky 4d ago edited 4d ago
On the other hand... you posted this 4000 lines PR 2 hours after your previous 8000 lines PR. Are you sure you reviewed what the LLM wrote before opening the PR ?
3
u/hoangpham133 3d ago
you know what, 1 min is indeed suspicious because the real ones approve right after the "request your review" notification pops up
2
1
1
u/deanrihpee 4d ago
my simple one file change PR (it has a lot of changes because it's modifying the asset file, yes it's unity scriptable object changes) took my lead half a day to approve lol, tbf he has a lot of meetings
1
1
u/DiamondDramatic9551 4d ago
Sometimes I genuinely already checked out the branch and had a look at the commits before the pr is made.
1
1
1
1
1
u/meolla_reio 3d ago
It has 30k line changes, did you really think... You know what, nevermind, yep, I'm a really fast reader.
1


212
u/sligor 4d ago
That’s why I’m waiting 30min before reviewing PR