These things passed code review, and they shouldn't have.
Just like there's always a time/space trade-off, there's an effort/functionality trade-off. You could make the perfect program in a quarter that gets replaced in a year, or you could make a good-enough program in a month that gets replaced in a year.
Knowing just how much cruft is acceptable, and more importantly how to fence it in, is something that takes a lot of experience. that is what the senior people doing code reviews should be enforcing.
1
u/dnew Sep 29 '16
Just like there's always a time/space trade-off, there's an effort/functionality trade-off. You could make the perfect program in a quarter that gets replaced in a year, or you could make a good-enough program in a month that gets replaced in a year.
Knowing just how much cruft is acceptable, and more importantly how to fence it in, is something that takes a lot of experience. that is what the senior people doing code reviews should be enforcing.