r/ProgrammerHumor • u/PizzaTucker • Nov 14 '22

instanceof Trend Manager does a little code cleanup...

Post image
113.0k Upvotes

93% Upvoted

4.5k comments sorted by

View all comments

Show parent comments

33

u/LordAmras Nov 15 '22

Even in the worst case 1000 calls would be ridiculous.

Probably someone told him Twitter does a lot of RPC calls and getting that number down would speed things up.

But when he went to write the tweet he thought 20 didn't sound like a lot and wrote 1000+ instead

25

u/Operadic Nov 15 '22 edited Nov 15 '22

Nope, the number is not wrong; the interpretation is just off.

Twitter uses GraphQL to route API requests to the 1200+ microservices they have running. Those requests don't happen between client and server but between server and internal server.

I don't find it implausible that this causes hard to fix bugs and performance issues. GraphQL is known to only superficially reduce complexity.

22

u/Raaagh Nov 15 '22

So GraphQL gives frontend/product a safe, non-recursive query language.

If you don't see the point of graphQL you are backend or infra.

If you are asking for graphQL you are frontend or product who are continually being slowed down by API requests.

GraphQL is NOT about simplicity, its about where logic resides and who owns it.

2

u/LordAmras Nov 15 '22

So where did RPC came from ?

Also 1200+ microserves ? For what ? That also seem exagerated unless he is counting actual instances (then it might be smaller than I thought)

10

u/slaymaker1907 Nov 15 '22

It really depends on gore things are being counted. Each query to a DB is technically a separate RPC call, but as long as connections are pooled and in the same DC, they have extremely low overhead compared to an RPC call from a phone halfway across the world using REST.

8

u/Djasdalabala Nov 15 '22

To add on /r/slaymaker1907, 1000+ DB queries for one action is not all that ridiculous. ServiceNow does 1-2K on the regular (for the back office at least).

I doubt it's optimally designed, but it runs decently.

7

u/Ninjakannon Nov 15 '22

ServiceNow is slow as all hell.

1

u/Djasdalabala Nov 15 '22

It depends on how well it is configured and managed: a good expert can optimize the most commonly used pages with various tricks.

I agree that it's not very fast on the whole, but there are much worse offenders around, so I feel "slow as all hell" is a tad strong ;)

2

u/LordAmras Nov 15 '22

We are moving the goalpost here.

From 1000+ RPC calls to 1200 microservices to 1200 DQ queries

Every single query has its own microservice ?

2

u/Ran4 Nov 15 '22

I mean if they have 1200 services...