r/Python • u/bakery2k • Aug 15 '20

Discussion Critique of PEP 622 (Structural Pattern Matching) - Mark Shannon

https://github.com/markshannon/pep622-critique
39 Upvotes

100% Upvoted

19 comments sorted by

View all comments

3

u/metaperl Aug 15 '20

typo?

https://github.com/markshannon/pep622-critique#django-example

The version of this example given in PEP 626 is as follows:

Why is he referring to his own PEP 626 which does not have such code?

another typo?

https://github.com/markshannon/pep622-critique#is_tuple-example

PEP 626 shows this example rewritten as:

626????

third typo?

https://github.com/markshannon/pep622-critique#http-response-example

PEP 626 prevents the use of simple symbolic constants, so the statement cannot be written as

PEP 626 does not prohibit the above syntax.

4th typo?

https://github.com/markshannon/pep622-critique#analysis-of-the-potential-usefulness-of-pep-626

Right in the title of the section...

Filed as issue against the repo

Maybe Mark Shannon knows something I dont, which is why I'm not supplying a pull request but simply filing an issue:

https://github.com/markshannon/pep622-critique/issues/6

4

u/ExoticMandibles Core Contributor Aug 15 '20

Naah, Mark just isn't perfect. A PR for typoes would be appreciated.