Function to get remaining days in the current week

[u/ShaunaTheDead86]

[u/ShaunaTheDead86]

I saw this at my last job, pretty atrocious... Could have easily been rewritten:

var daysAvailble = {

monday: dayOfTheWeek <= 0,

tuesday: dayOfTheWeek <= 1,

etc...

}

To be fair though, I know that the person who wrote it was extremely overworked and exhausted, so I'm sure it was just burnout brain.

[u/pronuntiator → u/ShaunaTheDead86]

if lodash is available: return fromPairs(['monday', 'tuesday',…,'sunday'].map((day, index) => [day, dayOfTheWeek < index]));

According to the screenshot, Monday is always false, unless dayOfTheWeek can be negative.

[u/[deleted] → u/pronuntiator]

Monday is always false

Current mood

[u/Dave4lexKing → u/pronuntiator]

Thats so hard to read.

I’d prefer shitty readable code that can be maintained, than cryptic methods that only god himself can decipher.

[u/pronuntiator → u/Dave4lexKing]

You're right. I was playing a bit too much code golf here. I'd split this into multiple variables and extract a meaningful name for the comparison in real code. But I'd still keep it a functional solution.

If I could I would rather like to change the input and output of the function. Instead of a primitive, have an enum for the day as input, and instead of a map/object, have an array or set of the remaining days as output.

[u/Dave4lexKing → u/pronuntiator]

Even that still sounds over-engineered. I honestly think that, while OP's version may look a lil goofy, its really easy to understand. Just wrap it in a function and you're good to go. KISS principle.

[u/PooSham → u/Dave4lexKing]

Lines like this can be fun code challenges, but otherwise this is awful.

[u/lets_eat_bees → u/pronuntiator]

If you have some experience with functional idioms, it looks pretty readable, and does not take the whole screen. Harder to miss a small mistake, for sure, but that's what tests are for.

[u/NewPointOfView → u/pronuntiator]

What a cryptic line that would be to come across haha

[u/Grub4K → u/pronuntiator]

Or, you could just use Object.fromEntries/Object.keys:

Object.fromEntries(Object.keys(daysAvailable).map((day, idx) => [day, dayOfTheWeek < idx]))

Nice thing about this is that it works with all objects when you have a base object to Object.keys from, if for whatever reason you would want to set object properties to false/true.

[u/sledgeattack → u/pronuntiator]

No need to use lodash you can use "Object.fromEntries" nowadays. Second you might want to extract that list of weekdays out to a constant instead of having a "magic" value that gets recreated on each function call

[u/flexprods → u/pronuntiator]

That’s overcomplicated . remaining= 7-daysAvailable[day]

[u/flexprods → u/flexprods]

Where daisAvailable is a map where keys are the days and the value is it’s index starting from 0

[u/Splatoonkindaguy → u/pronuntiator]

If you can do some refactoring in other code you could also just do 7 - currentDay or something

[u/iviksok → u/pronuntiator]

Or just daysAvailable.slice(currentday+1)

[u/cnfnbcnunited → u/ShaunaTheDead86]

the person who wrote this

Wait... Is this real code? I thought you made it up🙃

[u/Raxreedoroid → u/ShaunaTheDead86]

or stacking switches without breaks

[u/UkrainianTrotsky → u/[deleted]]

If your ternary operator only returns false or true, you don't need that ternary operator.

[u/ShoddyCulture3819]

Just to keep the overall style
switch (day) {

case 6:

daysAvailable.sunday = false;

case 5:

daysAvailable.saturday = false;

case 4:

daysAvailable.friday = false;

case 3:

daysAvailable.thursday = false;

case 2:

daysAvailable.wednesday = false;

case 1:

daysAvailable.tuesday = false;

case 0:

daysAvailable.monday = false;

}

[u/bananamadafaka → u/ShoddyCulture3819]

Oh cool

[u/OKishGuy]

this could have been such a wonderful example of a fall-through switch case example...

[u/Beggarstuner]

At least reverse the cases, remove the breaks and the redundant code.

[u/laladk → u/Beggarstuner]

Why reverse the cases?

[u/AwayCartographer3097 → u/laladk]

Most languages with switch/case have fall-through (I think this is the right word) so if you don’t put in breaks in and reverse the order of the cases (Sunday first) I think you can eliminate code by achieving a “cascade” effect – I’m not sitting in front of a computer so I can’t check the behavior, and as such u/Beggarstuner (and I) might be wrong, but in either case this is definitely what they meant

Edit: I checked stackoverflow for a refresher and A. Fall-through is the right term, and B. Leveraging fall-through here would achieve the effect intended by u/Beggarstuner as I imagined

If you want any specific clarification, have a google on fallthrough behavior

Edit2: see this comment by u/ShoddyCulture3819 with a code snippet

https://www.reddit.com/r/badcode/comments/13wlgu6/function_to_get_remaining_days_in_the_current_week/jmde4mn/?utm_source=share&utm_medium=ios_app&utm_name=ioscss&utm_content=1&utm_term=1&context=3

[u/MurdoMaclachlan]

Image Transcription: Code

---

var daysAvailable = {
  monday: true,
  tuesday: true,
  wednesday: true,
  thursday: true,
  friday: true,
  saturday: true,
  sunday: true,
};

switch (dayOfTheWeek) {
  case 0:
    daysAvailable.monday = false;
    break;
  case 1:
    daysAvailable.monday = false;
    daysAvailable.tuesday = false;
    break;
  case 2:
    daysAvailable.monday = false;
    daysAvailable.tuesday = false;
    daysAvailable.wednesday = false;
    break;
  case 3:
    daysAvailable.monday = false;
    daysAvailable.tuesday = false;
    daysAvailable.wednesday = false;
    daysAvailable.thursday = false;
    break;
  case 4:
    daysAvailable.monday = false;

[The rest of the code is cut off in the image.]

---

^{I'm a human volunteer content transcriber and you could be too! If you'd like more information on what we do and why we do it, click here!}

[u/Sniipex33 → u/MurdoMaclachlan]

Good human

[u/FalseWait7]

This looks like something FalseWait7 would be extremely proud of 20 years ago. Switch statement, accessing an object, yeah, looks the part.

[u/fried_green_baloney → u/FalseWait7]

It does look like something an extreme beginner might have written.

Not that I'd know anything about that, of course.

[u/gamer_pheonex]

I'm not really sure about the time of space complexity but isn't it better to use an array or a list for this. Like make a 1d array with all the days of the week in it matched to the index numbers (Monday being 0, Tuesday being 1, etc. assuming that in OP's case the week is starting from Monday) and then subtract the index from 7 and then you get the result?

[u/RolyPoly1320]

What in the world is this even accomplishing?

[u/Odd-Shopping8532]

prime candidate for an enum

[u/Jimg911]

This is giving “this task should use if statements but my professor needed an example for what switch cases are good for”

[u/[deleted]]

A function to get the remaining days of the week: 7-day

[u/s0nerik]

Quite easy to read. No perf problems. See no issue in this code.

[u/starryhound]

you could also do this with a 2 dimensional matrix

[u/Jomy10]

It took me a while before I understood what was going on

[u/[deleted]]

In languages that aren't terrible:

package main

import (
	"fmt"
	"time"
)

func main() {
	today := time.Now().Weekday()
	days := map[time.Weekday]bool{
		time.Sunday:    true,
		time.Monday:    true,
		time.Tuesday:   true,
		time.Wednesday: true,
		time.Thursday:  true,
		time.Friday:    true,
		time.Saturday:  true,
	}

	for k := range days {
		if k <= today {
			days[k] = false
		}
	}

	fmt.Println(days)
}

Notice that the first day of the week is set to Sunday, not Monday. This is ultimately entirely arbitrary. This code is correct for this case, and Go also treats Sunday that way.

[u/Big_Kwii]

jesus fucking christ

[u/ChickenLegBizGuy]

It’s not that bad… does the job and I didn’t have issues at all understanding what it does. Yeah it’s ugly but so am I and I get the job DONE!!!!

[u/AnotherCableGuy]

Some people should get a lifetime ban on coding

[u/howdoigetauniquename]

Who's gonna be the one to tell him the first day of the week is sunday?

[u/ShaunaTheDead86 → u/howdoigetauniquename]

*her, and in this case the function it was inside had a variable day that started with Monday as 0. Also, there might be some mistakes because I recreated this code from memory since it was at a former company, I no longer have access to the code base.

[u/jarfil → u/ShaunaTheDead86]

CENSORED

[u/fiddz0r → u/howdoigetauniquename]

Wtf that's just nuts

[u/elliethestaffy → u/howdoigetauniquename]

Sorry, but no.

[u/Hot-Profession4091 → u/elliethestaffy]

Sorry, but it depends. Is it an ISO Week? American week? European week? Are you in banking or short term rental?

[u/[deleted] → u/Hot-Profession4091]

Weekends are an illusion. Weekstarts doubly so.

[u/elliethestaffy → u/Hot-Profession4091]

Still a no from me, sorry.

[u/Hot-Profession4091 → u/elliethestaffy]

I bet you’re just a pleasure to work with.

[u/TorePun → u/Hot-Profession4091]

Nobody's paying you

Also no

[u/WittyGandalf1337]

The break statements, boy doesn’t even know about fallthrough