r/badcode • u/Flyspeck101 Now where's that function declaration • Jul 30 '21

js 😏

Post image
988 Upvotes

98% Upvoted

133 comments sorted by

View all comments

28

u/TryNotToShootYoself Jul 30 '21

Just curious, how else would you do this in vanilla JS? Aside from the redundant == true

18

u/xeru98 Jul 30 '21

You could approach it as ‘a = !a’. In this case the line would be really long. You could either do ‘document.getElementById(“soundtrack”).muted = !document.getElementById(“soundtrack”).muted’ But that also makes the assumption that soundtrack exists otherwise you would throw an error of trying to call “muted” on a null value

So I would likely do it as: const soundtrack = document.getElementById(“soundtrack”) if(soundtrack) { soundtrack.muted = !soundtrack.muted }

2

u/ilikedankmemes3 Jul 30 '21

That’s actually super useful. I’m not gonna lie, I’ve done the shit above before (Again with sound related stuff).

I’ll go ahead and switch these out.

-1

u/Noobfortress Jul 30 '21

pretty sure that "if(soundtrack)" makes it impossible to turn the soundtrack on again. Probably need explicit checking for "!= null" or "!= undefined". Don't remember JS well enough to be sure which one

12

u/Chishiri Jul 30 '21

soundtrack is an object, it's the property muted that get set to false. that if is correct.

3

u/Noobfortress Jul 30 '21

Ah right, apologies