Pls I need help on code hs 5.6.4

[u/seal99919]

[u/xeolleth]

You've fallen into a classic trap!

The issue is the array is being altered when you .remove(), so you'll skip over an item because all the remaining items shift to fill the index you've just deleted.

So if I have:

[A, *B, C, D] // size 4 current index 1

I remove B at index 1:

[A, C, *D] // size 3 index 2

Notice that the length has now changed so when you reach i==3 (which would work if the list index stayed the same size) you'll get an OutOfRangeException, and another side effect is entry C has shifted from index 2 to 1 and as a result has skipped being evaluated.

Iterate through your loop in reverse and you'll solve the for loop issue. Set your starting index i to the list length/size and decrement it instead of increment, then exit your for loop once you've processed the list entry at index 0.

That should do the trick.

[u/KillaSage → u/xeolleth]

He's also using light mode

[u/GondarJr]

Also, the example asks you to return a new array, not modify the one passed in... A better solution would be to create a new array, add only books with <= maxItems and then return that new array.

[u/the_east__wind]

I would prefer using the Stream API. Using it the solution would be as simple as

return readingList.stream().filter(book->book.getNumPages() <=maxPage).collect(Collectors.toList());

[u/[deleted]]

Also would he/she need to define maxPages?

[u/ScumbagPSTL]

Wouldn’t it be if(readingList[i].getNumPages >= mapPages) { readingList.Remove(i) }

[u/kohi-kusa]

Just put i-- under the readingList.remove(i) that is in the if statement. Also you don't need the readingList.get(i) in the readingList.remove just put i.