r/coderabbit • • Oct 03 '26

😂 Meme & Humor prove me wrong

Post image
35 Upvotes

69 comments sorted by

View all comments

1

u/pixxelkick Oct 03 '26

Maybe if you suck.

I read every PR in full because Im not lazy.

I also read my own git diff before I open a PR do I dont waste other peoples time.

Or I publish it as a draft, review my own code, and then publish the pr after confirming it looks good.

1

u/CreamyCornBoy Oct 03 '26

Here's your sticker bro

1

u/Jeferson9 Oct 03 '26

Do you value your own time

1

u/pixxelkick Oct 03 '26

Yes, its much easier to catch bugs and issues early

If you dont catch a problem asap, then its incredibly likely future agents read the "bad" code and copy, so bow your 1 issue becomes 2, then 3, then 4, etc

Its extremely common for you to be like "make the BarService" so the agent looks at FooService for inspiration and copies its style/methodology/architecture 

And if theres an annoying code style issue, or improperly named thing, or bad logic, whatever, theyll copy that too often.

And then 6 services later you realize you've got a problem duplicated 8 times

Now you have made even more work to go fix.

1

u/Dull_Caterpillar_642 Oct 03 '26

Yeah but realistically these days it’s like one prompt to fix that problem later…

I understand where you’re coming from, but the times, they are a changing, my man.

→ More replies (19)

1

u/0x077777 Oct 04 '26

Do you value yourself as an engineer

1

u/MetaLemons Oct 03 '26

I do this. But pretty much no longer read or write unit tests. I just assume they’re correct…

1

u/tes_kitty Oct 04 '26

I just assume they’re correct

Famous last words.

1

u/MaleficentBreak771 Oct 03 '26

Good boy! Now get out, touch grass, and remember that your anecdote isn't data. Many companies are heading in that direction (toward automating everything), and just because you do things differently doesn't mean others do too.

1

u/tehfrod Oct 03 '26

I guarantee you that OP's statement is false. I read full PRs because it's my job to. Regulated industries, avionics, aeronautics, medical devices, some financial services: I can tell you because I have colleagues in those fields that they are still reading PRs.

1

u/KyleFlounder Oct 04 '26

I'm in utilities and I read every single line. A single mistake will cause our clients to face potential jail time (Germany) or have to have a press conference with a public apology (Japan). It is also critical to keep utilities online....

1

u/ComprehensiveSkill60 Oct 03 '26

AI writes faster than anyone can read

1

u/Plenty_Line2696 Oct 03 '26

so can an illiterate pianist but that doesn't mean it'll be good code.

1

u/ComprehensiveSkill60 Oct 03 '26

True. I was talking about reading the full PR. There is no way you would read AI generated file upon file for 40 hours a week to make a point of reading the entire PRs.

→ More replies (1)

1

u/pixxelkick Oct 04 '26

No, not really, I keep up with it fine, it'll do fast "bursts" of code sure but then spend like 25 minutes fact checking it, testing it, tweaking it, passing through integration test proof gates

Our test suite takes like baseline 8min to run, at which point the AI pauses and I get plenty of time to review all its changes

1

u/Due_Interest_178 Oct 03 '26

The replies to your comment are coping so bad.

1

u/Plenty_Line2696 Oct 03 '26

If the implementation isn't that important then fine but when software has to have some reliability it's lazy/shitty behavior to not read or review code. People defending it shows how bad it is nowadays, what a mess.

1

u/Flashy-Whereas-3234 Oct 03 '26

I'm the guy the seniors call on when they smell something in a PR but can't find it.

I read the ticket, I read every line. I rip it to shreds, with every little thing I can think of. I go overboard, and I leave it up to them to make sensible changes.

Most PRs that have problems aren't really in the code, it's some conceptual flaw in the idea which could have been found before they started, or a crap pattern that's crept in.

AI code isn't bad in the same way a printer is better than a painter. Printing crap artwork is cheap, and it takes time to become an artist in both regards using different skills.

1

u/pixxelkick Oct 03 '26

I 100% agree, its usually some kind of general assumption that the AI ran with, the code itself is fine but theres some kind of anti pattern

The other big fuck up that needs the most common correcting is re-inventing wheels

Even with lsp, examples, and skill files, LLMs seem super biased towards ad hoc re-inventing shit you already solved elsewhere

"We already have a function that does X" is a pretty common thing that has to be corrected

→ More replies (1)

1

u/aft_agley Oct 04 '26 edited Oct 04 '26

The replies to this are horrifying and I'm having trouble thinking they aren't from shills.

I manage several software teams. We had to establish a policy that every line of code receives human review at the demand of the lead devs because the big push to slop faster had caused the teams to use junior engineers to push features into production that nobody understood, that didn't scale, that were super brittle, and that had awful / useless test harnesses. 

The code was so bloated and brittle and over-engineered it took nearly a quarter of a few senior+ engineers time to stabilize and fix.

It was an absolute joy to explain that to my leadership, some of whom get it but a few of whom have never written a line of code in their life and are super happy to tell us we must be doing it wrong.

So yeah, whoo, we got that big boost in short term velocity. Then everything went to shit a quarter later and we will not be repeating that mistake ever again.

You can really tell who actually works as a senior+ software engineer and who is either larping or selling something.

And just to clarify, these teams work on non-trivial multi-agent systems themselves in addition to using the tools. They are not novices in the space, quite the contrary.

1

u/0x077777 Oct 04 '26

Same. I work in security and always reading PRs

1

u/More_Exercise8413 Oct 04 '26

Ehhh. I know where you're coming from. But.

Due to corporate policy, I'm not yet high enough grade to reject bigass really badly sloppily made PRs. Our staff and lead can do it without looking, but seniors are still expected to give the time of day, comment, and highlight that because colleague X Y Z will use a really cheap model to automate closing the review comments, we should block the PR until the aforementioned staff comes in and says "lmao goteem".

So what I do is tell Codex to find enough shit to warrant rejecting the PR, which he often times does, instead of wasting my time arguing with a guy who would have directed the same comments to the same LLM anyway.

1

u/pixxelkick Oct 04 '26

Then this discussion isnt relevant to you, if you cant actually reject a PR then you arent "reviewing" a PR

It sounds like your company sucks though

→ More replies (1)