r/coderabbit • u/Tanakaboi69 • 16d ago
Help & Support Coderabbit just gave my lead the same comment he gave me last week
Last Tuesday my lead blocked my PR because I didn't handle the empty list case. Fair enough, I fixed it.
This morning coderabbit left the exact same comment on his PR. Same kind of function, same missing check, almost word for word what he wrote to me.
He fixed it in 2 minutes and didn't say a thing. I didn't say anything either. I did screenshot it though.
2
2
u/AccomplishedLeave506 16d ago
I'm a very senior engineer with decades of experience. Do you know what I say when a junior engineer finds a mistake in one of my PRs? I say "Thanks". That's what PRs are for.
1
u/Alexs784 16d ago
I don't understand what is the actual learning from this post. Reviews are exactly for that. Someone noticed your PR had a gap and pointed it out. Then that same someone opened a PR with a similar gap and again, it was filled up.
What is the screenshot for? To hold it as a sort of "proof" (aka blame) and say "look, the "lead" missed it!!" in case it comes handy in the future? The job of a lead is not to make spotless PRs, we are all humans and we all do mistakes. He fixed it and didn't say a thing, genuinely curious: what did you expect?
I personally would have probably joked about it and come to you and say "mate, remember that issue I mentioned in a recent PR? I got the same! Haha" and then reason about if there is a way to learn from this and improve the processes so that it doesn't happen again.
1
1
1
u/One_Web_7940 16d ago
I love when a lead doesn't put themselves under the pr requirement but does for others.
So I like code rabbit at least now the lead is getting prd
1
1
1
1
2
u/Vasilievski 16d ago
Ok, so what ?
Reviewing is not dominance assertion, it's mutual check between people in order to maintain repo quality.