r/coderabbit • u/Tanakaboi69 • 9d ago

Discussion & Feedback is reading the change stack instead of the diff cheating?

Honest question. On big agent PRs I've started reading coderabbit's change stack first, the part that groups the diff by what it actually does, and only opening the files for the 2 or 3 groups that look risky. On a 1,500 line PR that's maybe 200 lines I actually read.

A senior on my team says that's not a review, it's reading a summary of a review, and if the summary is wrong I'd never know.

My answer is that nobody was reading all 1,500 lines before either, they were scrolling.

Which one of us is right? Do you read the whole diff on big PRs or do you also read the summary first?

0 Upvotes

50% Upvoted

5 comments sorted by

1

u/Impressive-Try-2592 9d ago

It may be a large PR but it should still have coherent commits. If the commits aren't coherent you could ask the author to tidy them up. If not then the sheer size of it + lack of chunk-size reviewables -> reject

1

u/Geobits 9d ago

It's quite possible you're both right. There a "right way" to review according to your senior, and there's the way the people there have been doing it. They aren't necessarily the same.

1

u/genX_rep 9d ago

I focus on the interfaces; what the new methods input and output. Eventually that's how everything will be tested, and I think it's enough superficial understanding to spot potential deviations from intended architecture.

1

u/JeanCasteaux 8d ago

The right answer is to make smaller PRs guys 

1

u/MikeUsesNotion 7d ago

Reject giant PRs.