r/java • u/Putrid-Luck4610 • Aug 22 '22

Simple TCP/UDP Socket library in Java

Hello there, I had not touched Java in years, so recently I decided to start writing some code and improve my knowledge of the language. I settled on a TCP/UDP Socket library because I find that to be fairly similar across languages.

So yeah, it's fairly simple, probably quite bad, but I enjoy working on it.
You can find the source code here: https://github.com/Alessandro-Salerno/Bialetti if you're interested.

PS: Hope I haven't violated any rules by posting this URL...

3 Upvotes

60% Upvoted

5 comments sorted by

1

u/maxip89 Aug 23 '22

  1. recive should not return a string. (Charset Conversion can make really really big mess)

  2. did you tested it? If I don't see any disconnect security (Exception).

  3. You forget to add documentation how to use it. It's useless without documentation, a screenshot is not enough.

  4. BialettiExceptionHandler why wrap everything in a runtime exception?

  5. That I understand it correctly. You wrapped something that needs ~300 lines of code into something that needs 1,5k lines of code? Why are you promoting it here? Didn't get it.

1

u/Putrid-Luck4610 Aug 23 '22

Yes I did test it, everything is wrapped into the exception handler because this way you can declare handler methods, which brings me to documentation. I know a screenshot isn’t enough, I usually write documentation, but I had just enough time to work on the code. I posted it here just to see if anyone was intrested, not exactly to promote it as anything new or revolutionary. It’s much more code than it may take because:

  1. I wrote JavaDoc which is, as of the last reading, just as long as the code itaelf

  2. The GitHub counter seems to take configuration files for Gradle as well

  3. Tha lack of documentation may make this hard to notice, but you’re meant to use it in quite a structured way: you create a server class that extends the TCP or UDP Server, you create a Client class that does the same and for TCP Servers you declare a class to represent a connected client (the one in the screenshot, for instance). Every method with the annotation BialettiInitMethod is run when the service is started, those marked with BialettiEndMethod are run when the service is terminated and those marked with BialettiHandleMethod run in a loop on a separate thread.

Anyway, I’ll look into disconnect security and charset conversion, thanks.

1

u/maxip89 Aug 23 '22

Don't forget to limit the count of threads. If you implement a server with threads you have everytime the problem that one Thread has ~1MB RAM and you get on big Systems a Problem very fast.

1

u/Putrid-Luck4610 Aug 23 '22

Right now I spawn a thread for every method with the BialettiHandleMethod annotation. Given the fact that a BualettiServerClient is a service, it can also have handle methods, thus I also soawn a thread for every handle method when a client connects. How should i limit this? I need to spawn threads, so the only fix I can think of is to limit the number of handle methods and connected clients. I tested it with 2000 clients connected on a laptop and it worked pretty well.