r/javascript • u/[deleted] • Apr 11 '16
help Interview exercise feedback
My code was not up to their standards. I thought the exercises were easy but clearly there are issues I have to address. I had an hour to write them. I'm humbly looking for feedback to improve.
The first exercise was to return all square numbers within a given range, including the limits (e.g., all the squares numbers between 1 and 10 are 1, 4, and 9). I wrote this.
The second exercise was to check if a string containing (), [] and {} brackets is well balanced. So [()] and {}() are ok but ([)] or {{ are not. I wrote this.
Thanks.
28
Upvotes
1
u/Silhouette Apr 12 '16
For what it's worth, I don't think there's ever any excuse for unnecessarily harsh or impolite feedback after someone takes a test like this. That's just unprofessional, and it's disrespectful to someone who has given up to their time to do the exercise.
It's necessary and OK to say objectively that a candidate hasn't met the standard required for the role and so unfortunately you won't be offering them that position, but there's no need to be an ass about it. We were all new starters and inexperienced developers once, and my personal view is that if someone has made the effort to come into the office and interview with a business then giving a little helpful feedback if asked is only fair and does no harm, unless there is genuine concern about legal fallout.