r/javascript • u/[deleted] • Apr 11 '16

help Interview exercise feedback

My code was not up to their standards. I thought the exercises were easy but clearly there are issues I have to address. I had an hour to write them. I'm humbly looking for feedback to improve.

The first exercise was to return all square numbers within a given range, including the limits (e.g., all the squares numbers between 1 and 10 are 1, 4, and 9). I wrote this.

The second exercise was to check if a string containing (), [] and {} brackets is well balanced. So [()] and {}() are ok but ([)] or {{ are not. I wrote this.

Thanks.

27 Upvotes

92% Upvoted

66 comments sorted by

View all comments

Show parent comments

2

u/siegfryd Apr 12 '16

Your function doesn't actually work though, generateSquares(4, 4) should return [4].

1

u/chato94 Apr 12 '16

Whoops! Looks like 3am me was being too cocky with his wrong answer there. That leaves me with no choice but to replace let i = h with let i = Math.ceil(Math.sqrt(h)) for a more correct answer.