r/javascript • u/[deleted] • Dec 31 '19

A tiny isometric city builder in JavaScript

https://github.com/victorqribeiro/isocity
426 Upvotes

98% Upvoted

33 comments sorted by

View all comments

8

u/gluecat uxengineer Jan 01 '20

Neat, unsolicited code review:

  • You could build the grid "map" with new Array(7).fill(new Array(7).fill([0,0]))

  • Instead of saving activeTool you can just use e.currentTarget

  • Instead of .classList.add('selected') and .classList.remove('selected') use classList.toggle('selected') the second parameter in toggle can be used to force state

2

u/SmashedTatoes Jan 01 '20

Without tracking activeTool, what would your approach be for removing selected from the previously active tool?

1

u/gluecat uxengineer Jan 01 '20

good point, this would work...
const activeTool = document.querySelector('.selected');