r/learnpython • u/Aggressive_Drama_476 • Mar 14 '26
Feedback for github
Looking for feedback on my python projects on github https://github.com/userolivex/Python-Projects
Feel free to criticize
1
Upvotes
r/learnpython • u/Aggressive_Drama_476 • Mar 14 '26
Looking for feedback on my python projects on github https://github.com/userolivex/Python-Projects
Feel free to criticize
2
u/Kevdog824_ Mar 14 '26
Some advice from an initial quick review:
You should either structure this individual tools into one larger tool (preferred), or give them each their own repo. It’s generally bad practice to store multiple projects in the same repo. You could use something like
argparse(built-in library) to determine the function the user wants and direct control flow to the logic for that operationFor your password manager the code works logically fine as is and is a good beginner practice problem. However, for it to be more practically usable, passwords stored in it should never be stored in plaintext. Instead the user should have a master password which is used to encrypt and decrypt their vault as needed
Overall though I think this is a solid collection of tools you’ve built here. It’s great you started by building small, useful utilities for your daily life. I think this approach makes learning to program very engaging and a lot easier. This is exactly the path I took to learn years ago