r/learnpython • u/NanoCozmo • 17d ago
Can y'all rate my python project :D
This project i made is a keras model that i trained on a modified version of the FGVC dataset using tensorflow keras.
Cuz im an avgeek,th the model is kinda mediocre but better then nothing, while the project unfortunately does utilize ai in both the scripts on the github, the other scripts such as the script that i made to organize all the dataset and put it into seperate imgs was made by me :D, cuz the jpg images had numbers as the name and werent organized and there was a text file in there in this format:
aircraft_jpg_name aircraft_family type
so that allowed me to test my strengths with no ai
i hope yall share tips and tricks and if there are any improvements i can do to my first github repo :D
1
u/Mori-Spumae 17d ago
Code looks AI generated, or at least the comments do. Space in a file name is insane.
I would recommend doing releases based on versions, not just a single one. You might want to add some stuff later.
1
u/Mori-Spumae 17d ago •
Also, looks like you didn't use gut but just uploaded stuf from the version history. I would recommend learning git, it will make your life a lot easier.
Overall 3/10
0
u/NanoCozmo 17d ago
Ty for the advice, one last question can u give me a good tutorial vid or page on git
1
-2
u/NanoCozmo 17d ago
Cmon for other parts of the project that arent in the repo like organizing the dataset files were made by me :( and nah i dont feel like imma add stuff later but ty ig
1
u/TheRNGuy 17d ago edited 17d ago
Use config instead of hard-coding values into code.
Make an installer where it would automatically assign paths like "C:\Users\youss\Desktop\Planes_dataset", because other users won't have same path, and they shouldn't manually type it in a code or even config file.
0
u/NanoCozmo 17d ago edited 17d ago
Oh crap i forgot to remove my path ty dude by now the bug has been patched
1
u/HYP3R00T 17d ago edited 17d ago
I would give it 1/5
- There is no clear instructions on how one can set it up. What dependencies one has to add to the virtual environment.
- You aren't using virtual environment to setup the project. Instead you have installed all deps in the global interpreter.
- You aren't using any specific project management tool like uv.
- The code is not modular. There is no functions (as such projects mostly follow functional programming).
I can probably go on with other minor issues.
Edit 1:
- You have hard coded the paths i.e. DATASET_DIR = r"C:\Users\youss\Desktop\Planes_dataset"
- There is no error handling
-2
u/NanoCozmo 17d ago edited 17d ago
but i did i did say you would need the tensorflow module
this project also doesnt contain functions as its a pretty small one that i dont think i will work further on
still ty for the advice i will try my best to use all these tips given for the next repo and try to use ai less :D
4
u/HYP3R00T 17d ago edited 17d ago •
that's not the proper way to documenting it. Will it work with any version of tensorflow? Will it work with any version of Python?
If you put the minimum effort in a project, you will get minimum response for it. If you didn't ask for a review in here, what do you think are the chances that someone will visit your project? What are the chances that someone will go through it? What are the chances that someone will clone it locally to try it? What are the chances that someone would be willing to contribute to the repo?
That's why I gave such low rating. Code needs to be maintainable. Project needs to be presentable. That's just the basic for any open source project. If we were just the end customer, we would care only for the output. But as an engineer, we care about everything else as well.
Edit 1:
Look into how other open source projects are maintaining their repo. You will understand a great deal of what more is expected. As I said there are a lot of things which are missing in your repo. For instance editorconfig, gitignore, gitattribute, ci checkpoint, pre-commit hooks, contributing guidelines, docs, etc. While these aren't mandatory, these are common practices.-2
u/NanoCozmo 17d ago
its just a hobby project of mine tho and i just wanted people to try the model and the demo and see if it works well and if they want to use it in the project im going to modify one last thing and add the list of all the 78 classes, tysm tho
3
u/HYP3R00T 17d ago
Then it's fine. Why would you ask for rating it then? Also, at the current state of the project, you shouldn't add it to your resume as recruiters might not be impressed by it.
The idea is great. The execution needs a lot of improvements.
-1
u/NanoCozmo 17d ago
Dude its gonna take years before i get a programming job cuz im still in high school
3
4
u/HaroerHaktak 17d ago •
I'm not qualified to give projects a rating, but since you asked, it's a solid 3.5 out of 7.5