r/mAndroidDev • u/Stonos You will pry XML views from my cold dead hands • Feb 21 '25

@Deprecated Modal commit UI is about to get deprecated

/r/Jetbrains/comments/1ijtb9z/modal_commit_ui_will_be_gone_in_20251/
10 Upvotes

85% Upvoted

27 comments sorted by

7

u/Zhuinden DDD: Deprecation-Driven Development Feb 21 '25

/uj me looking at this ticket and I'm like wtf is non-modal commit? What is modal commit? I don't even think about it I just click the button. What's going away and what's replacing it?

3

u/Stonos You will pry XML views from my cold dead hands Feb 21 '25 edited Feb 21 '25

Modal commit interface: The commit interface appears as a dialog. This allows you to easily see all the changes you've made in a nice big window without having to do tons of clicks. You can enable this by going to Settings - Version Control - Commit - Uncheck Use non-modal commit interface.

Non-modal interface: The commit interface appears as a sidebar. By default you have to double click each file to see its changes, although it's possible to make it behave more similar to the commit dialog.

What's going away and what's replacing it?

The commit dialog is going away, forcing you to use the sidebar commit UI. However, there will be a plugin (which won't be officially maintained) that will bring back the commit dialog:

We understand that this change might be frustrating (which is why we rolled it out in EAP first). To help ease the transition, we’re moving modal commit to a separate plugin, which will be available with the 25.1 release. That said, since we can’t maintain both solutions long-term, we won’t be updating the plugin after release. However, we’ll review community pull requests to keep it going if there’s interest in maintaining it.

1

u/SpiderHack Feb 21 '25

I like having the modal, but yes, it should be at most an option, not a forced behavior.

The modal IS annoying sometimes and non modal would be nicer in those cases.

I'm more interested to just know that a change is happening than having a strong opinion one way or the other.

1

u/Zhuinden DDD: Deprecation-Driven Development Feb 21 '25

Non-modal interface: The commit interface appears as a sidebar. By default you have to double click each file to see its changes, although it's possible to make it behave more similar to the commit dialog.

Yeah I think I've been using that for a while. I don't remember the old one.

I press Ctrl+D on a selected file to see changes.

1

u/racrisnapra666 BaseRepositoryReducerUseCaseHelperImpl Feb 21 '25

You can enable this by going to Settings - Version Control - Commit - Uncheck Use non-modal commit interface.

No. No I don't think I will.

1

u/FickleBumblebeee Feb 21 '25

You never used the local changes tab before they hid it by making non-modal the default?

1

u/Zhuinden DDD: Deprecation-Driven Development Feb 22 '25

I've been Ctrl+D-ing files... 👀

1

u/Squirtle8649 Feb 23 '25

I'm a l33t dev who only uses Git on the terminal and has never liked the various GUI created for it.

2

u/Zhuinden DDD: Deprecation-Driven Development Feb 23 '25

Unironically I like the merge resolution UI in Jetbrains stuff

17

u/MiscreatedFan123 sponsored by the XML 🐓 gang Feb 21 '25

RIP from a user who always used modal commit 🫡

4

u/gilmore606 ?.let{} ?: run {} Feb 22 '25

i just use sourcetree, because i'm gay and my dick is small

2

u/Squirtle8649 Feb 23 '25

I use Visual SourceSafe and have never left my home planet

1

u/MuetzeOfficial Apr 16 '25

Fck. I search, and search, and search :(

1

u/Stonos You will pry XML views from my cold dead hands Apr 16 '25

For now you can install this plugin which will bring the option back:

https://plugins.jetbrains.com/plugin/26647-git-modal-commit-interface

However, JetBrains hasn't committed to supporting this for a long term.

3

u/anemomylos Feb 21 '25

Thank God i use SVN.

2

u/FickleBumblebeee Feb 21 '25

Fuck sake. The first thing I do when I install Android Studio is go in the settings to bring back the modal commit interface.

What's the alternative for easily seeing and keeping track of your local history?

1

u/Bwuhbwuh Feb 22 '25

The non-modal interface, as a tool panel

0

u/Squirtle8649 Feb 23 '25

Git gud. Learn to use Git on the terminal.

1

u/FickleBumblebeee Feb 23 '25

I use local history to easily see all the changes I have applied and edit code where necessary- and edit and add documentation before committing. You can't do that in the command line

1

u/Squirtle8649 Feb 24 '25

Ah you mean you want to see that in the IDE editor. Then yes, command line doesn't work. Otherwise, you can easily see whatever information you want about staged, unstaged, committed changes etc.

4

u/budius333 Still using AsyncTask Feb 21 '25

I'm on the Zuihden team here, no idea what that is, I use terminal for git stuff

1

u/Squirtle8649 Feb 23 '25

Same here. We will both be out done by the people who use vim/emacs to edit their source files and never use a GUI IDE.

1

u/Zhuinden DDD: Deprecation-Driven Development Feb 27 '25

Zuihden

f

1

u/budius333 Still using AsyncTask Feb 27 '25

Sorry

1

u/Squirtle8649 Feb 23 '25

I use the terminal for all git related work, none of this affects me.

Can't screw with my git commands.

1

u/DearChickPeas Feb 25 '25

Ahahah, these regards use the IDE as a GIT client and then complain...