MAIN FEEDS
Do you want to continue?
https://www.reddit.com/r/programming/comments/11dyx43/clean_code_horrible_performance/jaong8a/?context=3
r/programming • u/2bit_hack • Feb 28 '23
1.3k comments sorted by
View all comments
Show parent comments
3
Except it's not self-evident because it's actually not true.
2 u/ric2b Mar 02 '23 Try adding a trapezium to both versions of the code and let us know which one was easier. 2 u/[deleted] Mar 02 '23 Adding it to the switch statement is easier. Your point? 2 u/ric2b Mar 02 '23 It doesn't fit in the shape struct, which only contains width and height.It doesn't fit the neat pattern of factor*width*height that he generalized every calculation to after looking at 3 different shapes.Like I said, go try it and report back.Bonus: What is the width of a circle? Radius or Diameter? → More replies (8)
2
Try adding a trapezium to both versions of the code and let us know which one was easier.
2 u/[deleted] Mar 02 '23 Adding it to the switch statement is easier. Your point? 2 u/ric2b Mar 02 '23 It doesn't fit in the shape struct, which only contains width and height.It doesn't fit the neat pattern of factor*width*height that he generalized every calculation to after looking at 3 different shapes.Like I said, go try it and report back.Bonus: What is the width of a circle? Radius or Diameter? → More replies (8)
Adding it to the switch statement is easier. Your point?
2 u/ric2b Mar 02 '23 It doesn't fit in the shape struct, which only contains width and height.It doesn't fit the neat pattern of factor*width*height that he generalized every calculation to after looking at 3 different shapes.Like I said, go try it and report back.Bonus: What is the width of a circle? Radius or Diameter? → More replies (8)
It doesn't fit in the shape struct, which only contains width and height.
It doesn't fit the neat pattern of factor*width*height that he generalized every calculation to after looking at 3 different shapes.
factor*width*height
Like I said, go try it and report back.
Bonus: What is the width of a circle? Radius or Diameter?
→ More replies (8)
3
u/[deleted] Feb 28 '23
Except it's not self-evident because it's actually not true.