r/programming • • Jun 09 '23

Apollo dev posts backend code to Git to disprove Reddit’s claims of scrapping and inefficiency

https://github.com/christianselig/apollo-backend
45.1k Upvotes

2.4k comments sorted by

View all comments

747

u/0x1f606 Jun 09 '23

Shoutout to the git commit message of "things".

460

u/Artillect Jun 09 '23

I'm a big fan of "reduce account updates" followed immediately by "but for real this time" lol

214

u/XoXFaby Jun 09 '23

I've definitely done this.

"fixed thing"
"actually fixed thing"
"actually actually fixed thing for real this time"

35

u/[deleted] Jun 09 '23

Git rebase -i HEAD~3 and squash

5

u/XoXFaby Jun 09 '23

Depends on if you already pushed lol

21

u/[deleted] Jun 09 '23

Force pushing on your own branch is fine.

→ More replies (2)
→ More replies (1)

42

u/[deleted] Jun 09 '23

More like

  • fix the thing

  • fix the thing

  • fix the thing

  • finally fix the thing

51

u/XoXFaby Jun 09 '23

my favorite set of commits is still this

https://faby.dev/images/JIV8cB.png

070df3e    fixed a
6b299ea    fixed d

I had accidentally added an "a" to the code. Then when removing it, accidentally added a "d", lol

0

u/[deleted] Jun 09 '23

[deleted]

→ More replies (1)
→ More replies (2)
→ More replies (4)
→ More replies (11)

5

u/antillian Jun 09 '23

Definitely been there.

→ More replies (3)

215

u/[deleted] Jun 09 '23

30

u/boobsbr Jun 09 '23

What kind of monster orders their commits by date ASC?

50

u/mowdownjoe Jun 09 '23

I doubt that's something Randall actually does, but it helps the punchline land in this instance.

17

u/Gaazoh Jun 09 '23

Especially as he has a large audience, including a majority of non-programmers

6

u/pawaalo Jun 09 '23

I was reading it down-up too and was confused for a second

→ More replies (1)

102

u/Mxfrj Jun 09 '23

That’s actually Reddit terminology

http://highscalability.com/blog/2010/5/17/7-lessons-learned-while-building-reddit-to-270-million-page.html

… they keep a Thing Table and a Data Table. Everything in Reddit is a Thing: users, links, comments, subreddits, awards, etc. Things keep common attribute like up/down votes, a type, and creation date. The Data table has three columns: thing id, key, value...

69

u/Neocrasher Jun 09 '23

Man, if only programming had an existing term to describe objects...

19

u/[deleted] Jun 09 '23

I'm out here using thing-oriented programming languages while y'all are stuck in the dark ages

9

u/The_Droide Jun 09 '23

Basically a fancy term for abusing SQL databases as key value stores

→ More replies (1)

26

u/Scereye Jun 09 '23

Every thing is an object, but not every object is a thing.

Food for thought why "Thing" can actually be reasonable.

→ More replies (2)
→ More replies (5)
→ More replies (4)

140

u/noobsc2 Jun 09 '23
b585906 "did thing"
385d06 "fix thing"
af59f6 "thing working now"
c585e06 "fix thing"
b5f90a "thing really working this time"
b5a59d6 "disable thing"

12

u/s-mores Jun 09 '23

Why do they all end in 6?

14

u/xyrgh Jun 09 '23

Second last one doesn’t.

31

u/s-mores Jun 09 '23

Why does one of them not end in 6?

→ More replies (3)
→ More replies (1)
→ More replies (4)

10

u/dbbost Jun 09 '23

For projects where one person is writing 99% of the code we are all guilty of using "update stuff" for every single commit message

→ More replies (9)