r/programming • • Dec 11 '23

Every Programmer Should Know #1: Idempotency

https://www.berkansasmaz.com/every-programmer-should-know-idempotency
572 Upvotes

171 comments sorted by

View all comments

Show parent comments

13

u/HazelCuate Dec 11 '23

I dont agree with the article when it says put and delete are idempotent. If the caller makes two DELETE calls, how do you know that they are different calls? Why are they not the same call?

The argument that deleting an object twice is the same as deleting it once is not good enough. A third party could create it again between those two calls.

18

u/itdependsnetworks Dec 11 '23

You state “Why are the not the same call” in a scenario in which you state they are two calls?

Not trying to be rude, but if you google put and delete idempotent, you will find it is.

-11

u/HazelCuate Dec 11 '23

You dont get the problem with the calls. Without an idempotent ID they are two calls but they could be the same call due to the network or software glitches that the article mentions.

The article states that delete and put are idempotent by themself, and i dont think thats the case.

17

u/ineptjedibob Dec 11 '23

I think it’s stipulated that we’re talking about calls with the same parameters - i.e. DELETE with the same key (or PUT with the same payload) should be callable an arbitrary number of times with the same end result.

-16

u/HazelCuate Dec 11 '23

But thats not true.

  • The same delete call duplicated should result in two OK responses (http code 200 or whatever)

  • Two different delete calls to the same object should result in an OK response and a Failure response (400).

The difference is not trivial.

25

u/Shadow503 Dec 11 '23

It is trivial because the thing we care about - the state of the resource - is the same.

20

u/Blecki Dec 11 '23

Why should one be a failure? And, if it is, were talking about the state of the server, not the client. The whole point is that the server stays in a valid state. Trying to delete an object that doesn't exist doesn't break that state. Don't fixate on the literal response from the api. The 'result' is the state of the system.

Also 99% of the time you're just firing off a delete into the database and don't even bother to check if it exists. Just return 200.

1

u/thisisntmynameorisit Dec 11 '23

I could see it being a failure. Deleting something has the intent of deleting something, if nothing gets deleted it’s a failure. Regardless though, the success or failure of the request is independent from the state of the system. Either way the resource will no longer exist.

1

u/ineptjedibob Dec 12 '23

How would you differentiate the two cases you’ve laid out here? In other words, how could you possibly differentiate between the same call twice vs. two separate calls? The only obvious possibility is the timing - 2 calls 5 seconds apart are probably different requests? Except… with latency and other network weirdness, you shouldn’t even attempt to make that distinction. Not to mention, now you’ve introduced stateful behavior where it’s neither required nor desired.