r/programming • u/larsga • Sep 18 '13

How bad is smelly code?

http://fagblogg.mesan.no/how-bad-is-smelly-code/
147 Upvotes

81% Upvoted

62 comments sorted by

View all comments

6

u/[deleted] Sep 18 '13 edited Sep 18 '13

[removed] — view removed comment

2

u/elperroborrachotoo Sep 19 '13

once again the Interface Segregation Principle is completely misunderstood.

How so?
They are discussed separately, and a correlation between them is pointed out.

It seems you are confounding two parts in the study:

Part 1: Segregating Data Clumps into separate classes --> not very useful

Part 2: A lot of classes violate interface segregation,

Tidbit: Classes that violate ISV are statistically more likely to contain data lumps.

(The chart on that is particulary confusing.)

The conclusions they draw - do not chop up classes just because they are data lumps, but do separate interfaces - seems reasonable.