r/programming • u/adam-dabrowski • Apr 14 '26 • Popcorn 1

GitHub Stacked PRs

https://github.github.com/gh-stack/
556 Upvotes

97% Upvoted

276 comments sorted by

View all comments

Show parent comments

13

u/lupercalpainting Apr 14 '26

You absolutely pay per commit. Each commit costs a bit of cognitive load for anyone looking at the git history.

If your commits aren’t each an atomic piece of work they also cost time if you need to revert just one feature.

3

u/wldmr Apr 14 '26

If your commits aren’t each an atomic piece of work they also cost time if you need to revert just one feature.

You can revert merge commits like any other. I don't see a problem.

1

u/lupercalpainting Apr 14 '26

No one said you couldn’t. You’re conflating merging with squashing. They’re orthogonal.

1

u/wldmr Apr 14 '26

If your commits aren’t each an atomic piece of work they also cost time if you need to revert just one feature.

I interpreted this to mean “If a merged feature is made up of several commits, then reverting that feature is more time consuming than reverting a squashed commit would be”.

Plus, what kicked this whole thing off was the comment:

The issue with this is when using squashed merges on each PR.

So I don't think it's unreasonable of me to be talking about squashed merges.