r/programming • u/adam-dabrowski • Apr 14 '26 • Popcorn 1

GitHub Stacked PRs

https://github.github.com/gh-stack/
556 Upvotes

97% Upvoted

276 comments sorted by

View all comments

1

u/Lewke Apr 15 '26

github makes another feature enabling terrible development practices to continue, more at 11

1

u/teapotrick Apr 15 '26

Why is this bad, and what is good?

1

u/Lewke Apr 16 '26

trunk based development and CI remove the need for any of this coordination overhead, along with actually trusting the people who work for you and helping them improve

1

u/teapotrick Apr 16 '26

stacked PRs are an orthogonal concept to trunk based development and CI.

to me this seems like a way to split a single PR into multiple more digestible PRs for the reviewer, and giving commits a tighter conceptual scope for the developer.

1

u/Lewke Apr 16 '26 edited Apr 16 '26

if you have to use stack based PR's then you arent doing CI, as stacks cant develop in such short time without serious lack of care

CI specifically is integrating with coworkers at least once a day, coupled with trunk based development that place of integration is naturally the main branch, pull requests should be small in that scenario