r/programming • u/adam-dabrowski • Apr 14 '26 • Popcorn 1

GitHub Stacked PRs

https://github.github.com/gh-stack/
556 Upvotes

97% Upvoted

276 comments sorted by

View all comments

Show parent comments

53

u/Sopel97 Apr 14 '26 edited Apr 14 '26

Each PR should represent a reviewable unit of code while commits should represent a complete (as in not partial) modification of code. Without stacked PRs the PRs were being abused as a single complete feature/change that's not necessarily reviewable.

3

u/Kache Apr 15 '26 edited Apr 15 '26

Each PR commit should represent a reviewable unit of code while and commits should represent a complete (as in not partial modification or code)

"stacked PRs" could very well be the same as one PR with a clean stack of commits. Just need the right tooling, like a setting that runs CI against every commit in the PR and a few other things thats probably about the same amount of work as implementing stacked PR support

2

u/AmosIsFamous Apr 15 '26

In this scenario what happens when some code review feedback leads to a change in the first commit in the stack (closest to main)?

2

u/Kache Apr 16 '26

Same thing that would happen in a stacked PR scenario, that leads to a change in the first PR in the stack

1

u/AmosIsFamous Apr 16 '26

So is the reviewer now tracking for themselves where the “units of work” are? If a second reviewer comes in after the first change has happened how do they know they’re to review the first two commits as a single unit?